fix: address Copilot review comments on PR #259

- infra/main.parameters.json, infra/main.waf.parameters.json: change tags
  value from a string placeholder to an empty object {} to match the
  Bicep object parameter type and avoid deployment-time type errors.
- .github/workflows/test.yml: fix coverage XML path prefixing so we
  don't produce paths like src/backend-api/src/app/src/app/... Use
  repo-root prefix (src/backend-api/ and src/processor/) and strip any
  leading src/ from the original filename before prefixing.
- src/frontend/src/components/bottomBar.tsx: remove unused useNavigate
  import flagged by linting.
- src/frontend/src/pages/batchView.tsx: add null guard for batchSummary
  before reading batchSummary.error_count to avoid render-time crashes
  during initial load.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Shreyas-Microsoft

.github/workflows/test.yml

@@ -89,13 +89,17 @@ jobs:
           python <<'PY'
           import xml.etree.ElementTree as ET
           path = "src/backend-api/reports/coverage.xml"
-          prefix = "src/backend-api/src/app/"
+          prefix = "src/backend-api/"
           tree = ET.parse(path)
           root = tree.getroot()
           for cls in root.iter("class"):
               fname = cls.attrib.get("filename", "")
-              if fname and not fname.startswith(prefix):
-                  cls.attrib["filename"] = prefix + fname
+              if not fname or fname.startswith(prefix):
+                  continue
+              # Strip any leading "src/" so we don't double-prefix when coverage
+              # already emits filenames like "src/app/..." relative to the cwd.
+              normalized = fname[len("src/"):] if fname.startswith("src/") else fname
+              cls.attrib["filename"] = prefix + "src/" + normalized
           tree.write(path, xml_declaration=True, encoding="utf-8")
           PY
 
@@ -164,13 +168,17 @@ jobs:
           python <<'PY'
           import xml.etree.ElementTree as ET
           path = "src/processor/reports/coverage.xml"
-          prefix = "src/processor/src/"
+          prefix = "src/processor/"
           tree = ET.parse(path)
           root = tree.getroot()
           for cls in root.iter("class"):
               fname = cls.attrib.get("filename", "")
-              if fname and not fname.startswith(prefix):
-                  cls.attrib["filename"] = prefix + fname
+              if not fname or fname.startswith(prefix):
+                  continue
+              # Strip any leading "src/" so we don't double-prefix when coverage
+              # already emits filenames like "src/..." relative to the cwd.
+              normalized = fname[len("src/"):] if fname.startswith("src/") else fname
+              cls.attrib["filename"] = prefix + "src/" + normalized
           tree.write(path, xml_declaration=True, encoding="utf-8")
           PY
 

infra/main.parameters.json

@@ -42,7 +42,7 @@
         "value": "${AZURE_ENV_IMAGE_TAG}"
       },
       "tags": {
-       "value": "${AZURE_ENV_TAGS}"
+        "value": {}
       }
     }
 }

infra/main.waf.parameters.json

@@ -57,7 +57,7 @@
         "value": "${AZURE_ENV_VM_SIZE}"
       },
       "tags": {
-       "value": "${AZURE_ENV_TAGS}"
+        "value": {}
       }
     }
 }

src/frontend/src/components/bottomBar.tsx

@@ -1,6 +1,5 @@
 import { Button, Card, Dropdown, DropdownProps, Option } from "@fluentui/react-components"
 import React from "react"
-import { useNavigate } from "react-router-dom"
 
 // Define possible upload states
 const UploadState = {

src/frontend/src/pages/batchView.tsx

@@ -566,7 +566,7 @@ const BatchStoryPage = () => {
     }
 
     // Show the summary page when summary is selected
-    if (selectedFile.id === "summary") {
+    if (selectedFile.id === "summary" && batchSummary) {
       // Check if there are no errors and all JSON/YAML files are processed successfully
       const noErrors = (batchSummary.error_count === 0);
       const jsonYamlFileCount = getJsonYamlFileCount();