fix(infra): remove legacy OMSGallery/Security solution (ADO #43311)

The Microsoft.OperationsManagement/solutions 'Security' (OMSGallery/Security)
resource is a legacy artifact from the Log Analytics Agent (MMA) era. With the
modern Azure Monitor Agent + Data Collection Rule pipeline used here, the
SecurityEvent table is auto-provisioned by Azure Monitor on first ingestion
of the Microsoft-SecurityEvent stream. The OMSGallery solution is not
required and adds a marketplace plan resource for no functional benefit.

- Remove the securitySolution resource from infra/main.bicep and
  infra/main_custom.bicep.
- Drop the now-unnecessary dependsOn: [securitySolution] from the
  windowsVmDataCollectionRules module.
- Regenerate infra/main.json from main.bicep.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Shreyas-Microsoft

infra/main.bicep

@@ -433,35 +433,18 @@ module jumpboxVM 'br/public:avm/res/compute/virtual-machine:0.15.0' = if (enable
   }
 }
 
-// SFI: install the Azure Monitor "Security" solution on the Log Analytics
-// workspace so that the Microsoft-SecurityEvent stream produced by the data
-// collection rule below populates the SecurityEvent table. Same gate as the
-// DCR. (ADO #43311)
-resource securitySolution 'Microsoft.OperationsManagement/solutions@2015-11-01-preview' = if (enablePrivateNetworking && enableMonitoring) {
-  name: 'Security(${logAnalyticsWorkspaceResourceName})'
-  location: solutionLocation
-  plan: {
-    name: 'Security(${logAnalyticsWorkspaceResourceName})'
-    publisher: 'Microsoft'
-    product: 'OMSGallery/Security'
-    promotionCode: ''
-  }
-  properties: {
-    workspaceResourceId: logAnalyticsWorkspaceResourceId
-  }
-}
-
 // SFI: data collection rule that captures Windows Security audit success
 // (EventID 4624) and audit failure (EventID 4625) events from the jumpbox VM
 // and routes them to Log Analytics via the Microsoft-SecurityEvent stream.
+// The SecurityEvent table is auto-provisioned by Azure Monitor on first
+// ingestion via the DCR; no legacy OMSGallery/Security solution is needed.
 // (ADO #43311)
 var dataCollectionRulesResourceName = 'dcr-${solutionSuffix}'
 var dataCollectionRulesLocation = useExistingLogAnalytics
   ? existingLogAnalyticsWorkspace!.location
   : logAnalyticsWorkspace!.outputs.location
 module windowsVmDataCollectionRules 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if (enablePrivateNetworking && enableMonitoring) {
   name: take('avm.res.insights.data-collection-rule.${dataCollectionRulesResourceName}', 64)
-  dependsOn: [securitySolution]
   params: {
     name: dataCollectionRulesResourceName
     tags: allTags

infra/main.json

@@ -6,7 +6,7 @@
     "_generator": {
       "name": "bicep",
       "version": "0.43.8.12551",
-      "templateHash": "1101835156356663285"
+      "templateHash": "1952959724829141031"
     }
   },
   "parameters": {
@@ -348,25 +348,6 @@
         "tags": "[union(variables('existingTags'), parameters('tags'), createObject('TemplateName', 'Container Migration', 'Type', if(parameters('enablePrivateNetworking'), 'WAF', 'Non-WAF'), 'CreatedBy', variables('deployerIdentityName')))]"
       }
     },
-    "securitySolution": {
-      "condition": "[and(parameters('enablePrivateNetworking'), parameters('enableMonitoring'))]",
-      "type": "Microsoft.OperationsManagement/solutions",
-      "apiVersion": "2015-11-01-preview",
-      "name": "[format('Security({0})', variables('logAnalyticsWorkspaceResourceName'))]",
-      "location": "[variables('solutionLocation')]",
-      "plan": {
-        "name": "[format('Security({0})', variables('logAnalyticsWorkspaceResourceName'))]",
-        "publisher": "Microsoft",
-        "product": "OMSGallery/Security",
-        "promotionCode": ""
-      },
-      "properties": {
-        "workspaceResourceId": "[if(variables('useExistingLogAnalytics'), parameters('existingLogAnalyticsWorkspaceId'), reference('logAnalyticsWorkspace').outputs.resourceId.value)]"
-      },
-      "dependsOn": [
-        "logAnalyticsWorkspace"
-      ]
-    },
     "existingAiFoundryAiServices": {
       "condition": "[variables('useExistingAiFoundryAiProject')]",
       "existing": true,
@@ -18457,8 +18438,7 @@
       },
       "dependsOn": [
         "existingLogAnalyticsWorkspace",
-        "logAnalyticsWorkspace",
-        "securitySolution"
+        "logAnalyticsWorkspace"
       ]
     },
     "avmPrivateDnsZones": {
@@ -27430,8 +27410,8 @@
       },
       "dependsOn": [
         "appIdentity",
-        "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageBlob)]",
         "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageQueue)]",
+        "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageBlob)]",
         "virtualNetwork"
       ]
     },
@@ -35154,8 +35134,8 @@
       "dependsOn": [
         "aiFoundryAiServices",
         "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').cognitiveServices)]",
-        "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').openAI)]",
         "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').aiServices)]",
+        "[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').openAI)]",
         "virtualNetwork"
       ]
     },

infra/main_custom.bicep

@@ -411,35 +411,18 @@ module jumpboxVM 'br/public:avm/res/compute/virtual-machine:0.15.0' = if (enable
   }
 }
 
-// SFI: install the Azure Monitor "Security" solution on the Log Analytics
-// workspace so that the Microsoft-SecurityEvent stream produced by the data
-// collection rule below populates the SecurityEvent table. Same gate as the
-// DCR. (ADO #43311)
-resource securitySolution 'Microsoft.OperationsManagement/solutions@2015-11-01-preview' = if (enablePrivateNetworking && enableMonitoring) {
-  name: 'Security(${logAnalyticsWorkspaceResourceName})'
-  location: solutionLocation
-  plan: {
-    name: 'Security(${logAnalyticsWorkspaceResourceName})'
-    publisher: 'Microsoft'
-    product: 'OMSGallery/Security'
-    promotionCode: ''
-  }
-  properties: {
-    workspaceResourceId: logAnalyticsWorkspaceResourceId
-  }
-}
-
 // SFI: data collection rule that captures Windows Security audit success
 // (EventID 4624) and audit failure (EventID 4625) events from the jumpbox VM
 // and routes them to Log Analytics via the Microsoft-SecurityEvent stream.
+// The SecurityEvent table is auto-provisioned by Azure Monitor on first
+// ingestion via the DCR; no legacy OMSGallery/Security solution is needed.
 // (ADO #43311)
 var dataCollectionRulesResourceName = 'dcr-${solutionSuffix}'
 var dataCollectionRulesLocation = useExistingLogAnalytics
   ? existingLogAnalyticsWorkspace!.location
   : logAnalyticsWorkspace!.outputs.location
 module windowsVmDataCollectionRules 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if (enablePrivateNetworking && enableMonitoring) {
   name: take('avm.res.insights.data-collection-rule.${dataCollectionRulesResourceName}', 64)
-  dependsOn: [securitySolution]
   params: {
     name: dataCollectionRulesResourceName
     tags: allTags