fix: Resolved the tag issue#117
Merged
Merged
Conversation
Prajwal-Microsoft
approved these changes
Feb 19, 2026
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way tags are assigned to resource groups in both the
infra/main.bicepandinfra/main_custom.bicepfiles. The main improvement is switching from object spread syntax to theunion()function, which handles cases where resource group tags might be undefined, preventing errors and ensuring all tags are merged correctly.Tag assignment improvements:
union()function for merging tags, usingresourceGroup().tags ?? {}to handle cases where resource group tags may be undefined in bothinfra/main.bicep[1] andinfra/main_custom.bicep[2].TemplateName,Type,CreatedBy) are always included in the final tag set for the resource group in both files [1] [2].## PurposeDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information
This pull request updates how resource group tags are merged in both
infra/main.bicepandinfra/main_custom.bicepto ensure that tags are combined more safely and robustly, especially whenresourceGroup().tagsmight be null. The new approach uses theunion()function to merge tags, which helps prevent errors and improves maintainability.Improvements to tag merging logic:
resourceGroupTagsto use theunion()function, ensuring thatresourceGroup().tagsis safely merged (handles possible null values) with other tags and required template metadata in bothinfra/main.bicep[1] andinfra/main_custom.bicep[2].