chore: Dev merge to main#229
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fix: fixed CodQL issues for Container Migration.
fix: Refactor code structure for improved readability and maintainability
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges development changes into main, combining dependency updates and small refactors/bug fixes across the processor, backend API, and frontend.
Changes:
- Updated Python (uv/pyproject/lockfiles) and Node dependencies (notably
uuid, plus new processor npm deps). - Replaced several silent
except: passblocks with debug logging and minor flow/clarity adjustments. - Refactored a few integration points (backend DI registration, typing/protocol stubs, frontend UI logic cleanups).
Reviewed changes
Copilot reviewed 33 out of 37 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/processor/uv.lock | Updates locked Python dependencies (e.g., aiohttp, fastmcp, pytest) and related metadata. |
| src/processor/src/utils/agent_telemetry.py | Removes dead commented code; adds debug logs for previously swallowed exceptions; ensures None return when repository absent. |
| src/processor/src/tests/conftest.py | Clarifies intentional side-effect import of sitecustomize. |
| src/processor/src/steps/migration_processor.py | Adds debug logs where exceptions were swallowed; explicitly returns None at end of workflow run. |
| src/processor/src/services/queue_service.py | Replaces silent exception swallowing with debug logs; minor cleanup comment for GC. |
| src/processor/src/services/control_api.py | Adds debug logs for best-effort shutdown failures. |
| src/processor/src/libs/reporting/migration_report_generator.py | Adds debug logging when file size cannot be determined. |
| src/processor/src/libs/mcp_server/mermaid/mcp_mermaid.py | Adds explanatory comment for non-JSON CLI output handling. |
| src/processor/src/libs/mcp_server/datetime/mcp_datetime.py | Removes unreachable return statements in error paths. |
| src/processor/src/libs/agent_framework/qdrant_memory_store.py | Adds debug logging for best-effort cleanup failures. |
| src/processor/src/libs/agent_framework/azure_openai_response_retry.py | Adds debug logging for best-effort stream close failures. |
| src/processor/src/libs/agent_framework/agent_framework_helper.py | Replaces overload stub bodies with pass. |
| src/processor/pyproject.toml | Bumps processor Python dependency pins (aiohttp, fastmcp, pytest). |
| src/processor/package.json | Adds processor npm deps (dompurify, lodash-es) alongside mermaid. |
| src/processor/package-lock.json | Lockfile updates for added/bumped processor npm deps. |
| src/frontend/vite.config.js | Removes unused path import. |
| src/frontend/src/pages/processPage.tsx | Removes unused imports/state related to lastUpdateTime and config helpers. |
| src/frontend/src/pages/modernizationPage.tsx | Removes unused state/logic; adjusts summary rendering and file selection handling. |
| src/frontend/src/pages/landingPage.tsx | Removes unused imports/handlers; simplifies start-translating flow. |
| src/frontend/src/pages/batchView.tsx | Removes unused UI code; adjusts summary rendering condition. |
| src/frontend/src/msal-auth/apiHeaders.ts | Removes unused getMsalInstance import; keeps header utilities and debugging helper. |
| src/frontend/src/main.jsx | Adjusts config initialization variable to avoid misleading default assignment. |
| src/frontend/src/components/uploadButton.tsx | Removes unused imports/state and dead handler. |
| src/frontend/src/components/bottomBar.tsx | Removes unused useState import. |
| src/frontend/src/components/batchHistoryPanel.tsx | Minor cleanup (formatting and dead commented categorization logic). |
| src/frontend/src/commonComponents/ProgressModal/progressModal.tsx | Ensures progress shows 100% when processingCompleted, regardless of error. |
| src/frontend/src/api/utils.tsx | Fixes error grouping to include only files with error_count > 0. |
| src/frontend/package.json | Bumps uuid to ^14; adds uuid override alignment entry. |
| src/frontend/package-lock.json | Lockfile updates for uuid@14 and lockfile cleanup (e.g., libc removals). |
| src/frontend/frontend_server.py | Removes unused HTMLResponse import and unused referer header variable. |
| src/backend-api/uv.lock | Updates backend API lock overrides and package versions (dotenv, multipart, requests, werkzeug, pygments). |
| src/backend-api/src/tests/application/test_dependency_injection.py | Updates DI test to register InMemoryDataService directly. |
| src/backend-api/src/app/libs/base/SKLogicBase.py | Fixes missing self param; changes overload stubs to pass. |
| src/backend-api/src/app/libs/base/fastapi_protocol.py | Adds method body for protocol include_router to aid type checking. |
| src/backend-api/src/app/application.py | Registers InMemoryDataService directly instead of lambda factory. |
| src/backend-api/pyproject.toml | Pins backend dependencies (dotenv/multipart) and expands override list (requests/werkzeug/pygments). |
| scripts/validate_bicep_params.py | Adds clarifying comment for fallback parsing behavior. |
Files not reviewed (2)
- src/frontend/package-lock.json: Language not supported
- src/processor/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
src/frontend/src/pages/batchView.tsx:573
- The summary rendering branch no longer checks
batchSummaryfor null, but the code inside immediately dereferences it (e.g.,batchSummary.error_count). SincebatchSummaryis initialized asnull, selecting the Summary file before the fetch completes can throw at render time. Restore the null-guard (e.g.,selectedFile.id === "summary" && batchSummary) or use optional chaining/defaults inside this block.
// Show the summary page when summary is selected
if (selectedFile.id === "summary") {
// Check if there are no errors and all JSON/YAML files are processed successfully
const noErrors = (batchSummary.error_count === 0);
const jsonYamlFileCount = getJsonYamlFileCount();
const allJsonYamlFilesProcessed = (jsonYamlFileCount >= 0); // All existing JSON/YAML files are considered processed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: Bicep Parameter validation email format change
Brings the following hotfix/doc commits from main back into dev: 3552f12 Merge PR #221 (psl-addBicepVer) 7474d9f docs: add Bicep CLI prerequisite to local deployment guide f0e9975 Merge PR #206 (hotfix/disable-buildx-provenance-acr-standard) 76fb954 fix(ci): disable buildx provenance to fix ACR Standard push (400) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chore: merge-down main into dev
fix: fixed all copilot comments
Roopan-Microsoft
approved these changes
May 11, 2026
Prajwal-Microsoft
approved these changes
May 11, 2026
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes dependency updates, minor refactoring, and small bug fixes across both backend and frontend components. The most significant changes are dependency version bumps (notably for
uuidand Python packages), adjustments to dependency injection patterns, and small improvements to code clarity and correctness.Dependency Updates
uuidpackage from version 11.x to 14.x in bothpackage.jsonandpackage-lock.jsonfor the frontend, with corresponding lockfile and binary path changes. [1] [2] [3] [4]python-dotenvandpython-multipartto specific versions, and addedrequests,werkzeug, andpygmentsto the override list inpyproject.toml. [1] [2]Backend Refactoring and Bug Fixes
InMemoryDataServiceto register the class directly instead of a lambda factory, simplifying service registration and its corresponding unit test. [1] [2]SKLogicBase.py: added missingselfparameter toexecute, replaced...withpassin overloaded methods. [1] [2] [3]validate_bicep_params.pyby adding a comment explaining the fallback behavior when JSON parsing fails.pass) forinclude_routerin theFastAPIWithContextprotocol for improved type checking and clarity.Frontend Improvements and Bug Fixes
renderErrorContentby filtering files witherror_count > 0instead of a truthy check, ensuring only files with actual errors are shown.ProgressModalto always return 100% ifprocessingCompleted, regardless of errors.Other Dependency and Lockfile Cleanups
libcfields from multiple entries inpackage-lock.jsonfor a cleaner lockfile. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]These changes collectively improve dependency management, code clarity, and correctness across the project.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information