Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dda710a
fix: fixed CodQL issues for Container Migration.
VishalS-Microsoft Apr 29, 2026
5174d50
Merge branch 'dev' into psl-codequlity-cmv2
VishalS-Microsoft May 4, 2026
20ed057
resloved copoilot comments
VishalS-Microsoft May 5, 2026
ac67769
Format changes
NirajC-Microsoft May 5, 2026
1594df3
Format changes 2
NirajC-Microsoft May 5, 2026
e1907d9
Format changes 2
NirajC-Microsoft May 5, 2026
1cd7ee1
Format changes 3
NirajC-Microsoft May 5, 2026
ba5e413
Refactor code structure for improved readability and maintainability
Dhanushree-Microsoft May 6, 2026
a9c7a80
Potential fix for pull request finding
Dhanushree-Microsoft May 6, 2026
97c4dce
Potential fix for pull request finding
Dhanushree-Microsoft May 6, 2026
8477b3e
Merge branch 'dev' into psl-codequlity-cmv2
VishalS-Microsoft May 6, 2026
f78da57
Update email format 7
NirajC-Microsoft May 7, 2026
f4405cd
Update email format 5
NirajC-Microsoft May 7, 2026
c4ac793
Update email format 8
NirajC-Microsoft May 7, 2026
f9b4b68
Merge pull request #210 from microsoft/psl-codequlity-cmv2
Roopan-Microsoft May 7, 2026
6ae8b02
Merge pull request #222 from microsoft/con-mig-depdh
Roopan-Microsoft May 7, 2026
ebd74d3
Merge pull request #228 from NirajC-Microsoft/dev
Roopan-Microsoft May 8, 2026
6136880
Merge branch 'main' into psl-main-mergedown-dev
Shreyas-Microsoft May 8, 2026
2ac4a94
Merge pull request #231 from microsoft/psl-main-mergedown-dev
Roopan-Microsoft May 8, 2026
094f7ac
fix: fixed all copilot comments
VishalS-Microsoft May 11, 2026
6b3dce7
Merge pull request #234 from microsoft/psl-fixcopilotcomments-cm
Roopan-Microsoft May 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/validate_bicep_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def parse_parameters_env_vars(json_path: Path) -> dict[str, list[str]]:
data = json.loads(sanitized)
params = data.get("parameters", {})
except json.JSONDecodeError:
pass
pass # File is not valid JSON after azd variable substitution; fall through to regex scan

# Walk each top-level parameter and scan its entire serialized value
# for ${VAR} references from the original text.
Expand Down
7 changes: 5 additions & 2 deletions src/backend-api/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ dependencies = [
"fastapi[standard]==0.116.1",
"httpx==0.28.1",
"pydantic-settings==2.10.1",
"python-dotenv",
"python-multipart==0.0.22",
"python-dotenv==1.2.2",
"python-multipart==0.0.26",
"protobuf==7.34.0",
"sas-cosmosdb==0.1.4",
"semantic-kernel[azure]==1.40.0",
Expand All @@ -34,6 +34,9 @@ override-dependencies = [
"aiohttp==3.13.4",
"azure-core==1.38.0",
"urllib3==2.6.3",
"requests==2.33.0",
"werkzeug==3.1.4",
"pygments==2.20.0",
"black==26.3.1",
"cryptography==46.0.7",
"pyjwt==2.12.0",
Expand Down
2 changes: 1 addition & 1 deletion src/backend-api/src/app/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def _register_dependencies(self):
)
.add_singleton(ILoggerService, ConsoleLoggerService)
.add_transient(IHttpService, HttpClientService)
.add_singleton(IDataService, lambda: InMemoryDataService())
.add_singleton(IDataService, InMemoryDataService)
)

def run(self, host: str = "0.0.0.0", port: int = 8000, reload: bool = True):
Expand Down
6 changes: 3 additions & 3 deletions src/backend-api/src/app/libs/base/SKLogicBase.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def _init_agent(self):
"""
raise NotImplementedError("This method should be overridden in subclasses")

async def execute(func_params: dict[str, any]):
async def execute(self, func_params: dict[str, any]):
raise NotImplementedError("Execute method not implemented")
Comment thread
VishalS-Microsoft marked this conversation as resolved.

@overload
Expand All @@ -92,7 +92,7 @@ async def execute_thread(
thread: AgentThread | AssistantAgentThread | AzureAIAgentThread = None,
) -> tuple[str, AgentThread | AssistantAgentThread | AzureAIAgentThread]:
"""When response_format is None, returns string response."""
...
pass

@overload
async def execute_thread(
Expand All @@ -102,7 +102,7 @@ async def execute_thread(
thread: AgentThread | AssistantAgentThread | AzureAIAgentThread = None,
) -> tuple[T, AgentThread | AssistantAgentThread | AzureAIAgentThread]:
"""When response_format is provided, returns typed Pydantic BaseModel response."""
...
pass

@abstractmethod
async def execute_thread(
Expand Down
3 changes: 2 additions & 1 deletion src/backend-api/src/app/libs/base/fastapi_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ class FastAPIWithContext(Protocol):
app_context: AppContext

# Include essential FastAPI methods for type checking
def include_router(self, *args, **kwargs) -> None: ...
def include_router(self, *args, **kwargs) -> None:
pass


def add_app_context_to_fastapi(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def test_factory_registration():
app_context = AppContext()

# Register with factory function
app_context.add_singleton(IDataService, lambda: InMemoryDataService())
app_context.add_singleton(IDataService, InMemoryDataService)

data_service = app_context.get_service(IDataService)
assert isinstance(data_service, InMemoryDataService)
Expand Down
40 changes: 20 additions & 20 deletions src/backend-api/uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions src/frontend/frontend_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from dotenv import load_dotenv
from fastapi import FastAPI, Request
from fastapi.middleware.cors import CORSMiddleware
from fastapi.responses import FileResponse, HTMLResponse, JSONResponse
from fastapi.responses import FileResponse, JSONResponse
from fastapi.staticfiles import StaticFiles

# Load environment variables from .env file
Expand Down Expand Up @@ -42,7 +42,6 @@ async def serve_index():
async def get_config(request: Request):
# Only serve config to same-origin requests by checking the Referer/Origin
origin = request.headers.get("origin") or ""
referer = request.headers.get("referer") or ""
host = request.headers.get("host") or ""
if origin and not origin.endswith(host):
return JSONResponse(status_code=403, content={"detail": "Forbidden"})
Expand Down
Loading
Loading