Skip to content

fix: fixed all copilot comments#234

Merged
Roopan-Microsoft merged 1 commit into
devfrom
psl-fixcopilotcomments-cm
May 11, 2026
Merged

fix: fixed all copilot comments#234
Roopan-Microsoft merged 1 commit into
devfrom
psl-fixcopilotcomments-cm

Conversation

@VishalS-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request includes several updates across both backend and frontend code, focusing on type annotation improvements, a bug fix in the file selection logic on the modernization page, and a minor cleanup in the queue processing service. The most significant change is the frontend bug fix, which corrects how files are matched for display.

Frontend bug fix:

  • Fixed a bug in the modernization page so that the UI correctly matches the selected file by comparing file.id (the UI identifier) instead of file.fileId (the server identifier), ensuring the correct file is shown in the progress view.

Backend type annotation improvements:

  • Updated type annotations in SKLogicBase.py to use Any instead of any in both the import statement and the execute method parameter, aligning with Python typing conventions. [1] [2]

Backend cleanup:

  • Removed an unnecessary assignment to migration_processor = None in the queue processing service, as it was only needed for garbage collection and is now redundant.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
libs/base
   SKLogicBase.py46460%1–2, 4–5, 14–15, 18, 21–24, 28, 35–36, 38–40, 42–43, 56–57, 59–60, 64–65, 69, 71, 76, 78, 82, 84–85, 87–88, 95, 97–98, 105, 107–108, 114, 116–120
TOTAL274024789% 

Tests Skipped Failures Errors Time
44 0 💤 0 ❌ 0 🔥 15.370s ⏱️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a small set of targeted fixes across the frontend and backend: it corrects file selection matching on the Modernization page UI, tightens Python type annotations in the SK logic base class, and removes a redundant reference-release assignment in the queue processing service.

Changes:

  • Fix Modernization page progress-view file matching to use the UI’s internal file.id (instead of server file.fileId).
  • Update SKLogicBase.execute typing to use typing.Any (and import Any) for correct Python type annotations.
  • Remove the redundant migration_processor = None cleanup assignment from the queue worker message processing flow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/processor/src/services/queue_service.py Removes an unnecessary local reference reset in _process_queue_message while preserving existing error-handling flow.
src/frontend/src/pages/modernizationPage.tsx Fixes progress view file lookup to align with the internal UI identifier (file.id).
src/backend-api/src/app/libs/base/SKLogicBase.py Corrects typing by importing/using Any for execute parameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Roopan-Microsoft Roopan-Microsoft merged commit 6b3dce7 into dev May 11, 2026
16 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-fixcopilotcomments-cm branch May 11, 2026 10:34
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants