Skip to content

Revert "fix: enhance message handling and context management in orchestrators"#278

Merged
Roopan-Microsoft merged 1 commit into
devfrom
revert-277-psl-agentframework
Jun 10, 2026
Merged

Revert "fix: enhance message handling and context management in orchestrators"#278
Roopan-Microsoft merged 1 commit into
devfrom
revert-277-psl-agentframework

Conversation

@Roopan-Microsoft

Copy link
Copy Markdown
Collaborator

Reverts #277

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL309720893% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
588 0 💤 0 ❌ 0 🔥 22.406s ⏱️

@github-actions

Copy link
Copy Markdown

Coverage

Processor Coverage Report •
FileStmtsMissCoverMissing
src/processor/src/libs/agent_framework
   agent_builder.py1230100% 
   agent_info.py240100% 
   azure_openai_response_retry.py37114062%91, 201, 209, 231, 257, 267–269, 393, 400–403, 405–407, 413–415, 432, 453–454, 459–462, 465–468, 470–473, 475, 485–487, 489–492, 494–497, 499–503, 505, 513–515, 517, 540–545, 547–549, 555–556, 560–563, 567, 570, 578–579, 585–586, 591, 593, 614, 620–622, 626–627, 643–644, 646–649, 653, 656, 664–665, 671–673, 675–678, 680–691, 694, 701–702, 727–728, 735–736, 738, 742, 745–746, 750–751, 753–755, 763, 765–767, 769–771, 773–774, 784
   groupchat_orchestrator.py5439083%129–130, 137–138, 143–144, 471, 474–478, 480, 482–483, 486, 489, 492, 494, 496–499, 506–507, 514–515, 522–523, 526–528, 530–531, 536–538, 541–542, 547, 550–552, 555–556, 561, 564, 570, 573, 577, 579–583, 587–588, 594, 597, 601, 606, 609, 620–621, 623, 625–626, 628, 638–639, 641, 734, 908, 927, 929, 931, 960, 1089, 1091, 1206, 1215, 1217, 1262–1263, 1266, 1287–1290, 1308
   shared_memory_context_provider.py1221190%111, 138, 219, 230, 234, 239, 282, 287, 310–312
src/processor/src/libs/base
   orchestrator_base.py1675070%65, 71, 74–77, 83–84, 86–87, 130, 141, 146, 151–152, 156, 164, 166, 168, 175–176, 183, 189, 191, 198, 202, 211, 215, 220, 222–223, 225, 324–326, 329, 335, 342–344, 371–373, 376, 383, 390–392, 443–444
src/processor/src/steps
   migration_processor.py2644084%88–89, 145–146, 160, 187, 222–223, 229–230, 234, 238, 309–312, 315–318, 322–323, 336–337, 395–396, 496–497, 547–548, 555–556, 594–595, 613–614, 678–679, 703, 732
TOTAL575273687% 

Tests Skipped Failures Errors Time
812 0 💤 0 ❌ 0 🔥 20.169s ⏱️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts changes from #277 by restoring earlier agent/orchestrator integration patterns in the processor: streaming execution uses run_stream, workflow construction uses builder registration/chaining, and shared-memory context integration uses invoking/invoked hooks.

Changes:

  • Switch workflow execution back to run_stream() in processor and group chat orchestration.
  • Rework workflow construction to use WorkflowBuilder().register_executor(...).set_start_executor(...).add_edge(...).build().
  • Update shared memory context provider interface/tests to invoking() + invoked() and adjust AgentBuilder call patterns.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/processor/src/tests/unit/steps/test_migration_processor_run.py Updates workflow mock to use run_stream for streaming tests.
src/processor/src/tests/unit/libs/agent_framework/test_shared_memory_context_provider.py Updates tests to validate invoking()/invoked() behavior and new request/response shapes.
src/processor/src/tests/unit/libs/agent_framework/test_groupchat_orchestrator_internals.py Adjusts builder mocking to match the updated groupchat builder chaining API.
src/processor/src/tests/unit/libs/agent_framework/test_agent_builder.py Updates expectations to match Agent construction via keyword params (vs nested default options).
src/processor/src/steps/migration_processor.py Reverts workflow build pattern and switches streaming loop to workflow.run_stream(...).
src/processor/src/libs/base/orchestrator_base.py Adjusts agent creation (store/context provider wiring) to match reverted context provider usage.
src/processor/src/libs/agent_framework/shared_memory_context_provider.py Reverts provider lifecycle to invoking()/invoked() and changes memory injection to return a context object.
src/processor/src/libs/agent_framework/groupchat_orchestrator.py Uses WorkflowBuilder as the groupchat builder and switches workflow streaming to run_stream.
src/processor/src/libs/agent_framework/azure_openai_response_retry.py Removes orphan tool-message cleanup during context trimming and simplifies Azure endpoint kwarg handling.
src/processor/src/libs/agent_framework/agent_info.py Changes tools typing/validation surface for AgentInfo.
src/processor/src/libs/agent_framework/agent_builder.py Reverts Agent construction to pass model/options as direct kwargs rather than building ChatOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/processor/src/libs/agent_framework/agent_info.py
@Roopan-Microsoft Roopan-Microsoft merged commit 6a3a9fc into dev Jun 10, 2026
12 of 14 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants