Revert "fix: enhance message handling and context management in orchestrators"#278
Merged
Merged
Conversation
Roopan-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
Coverage Report •
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from #277 by restoring earlier agent/orchestrator integration patterns in the processor: streaming execution uses run_stream, workflow construction uses builder registration/chaining, and shared-memory context integration uses invoking/invoked hooks.
Changes:
- Switch workflow execution back to
run_stream()in processor and group chat orchestration. - Rework workflow construction to use
WorkflowBuilder().register_executor(...).set_start_executor(...).add_edge(...).build(). - Update shared memory context provider interface/tests to
invoking()+invoked()and adjust AgentBuilder call patterns.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/processor/src/tests/unit/steps/test_migration_processor_run.py | Updates workflow mock to use run_stream for streaming tests. |
| src/processor/src/tests/unit/libs/agent_framework/test_shared_memory_context_provider.py | Updates tests to validate invoking()/invoked() behavior and new request/response shapes. |
| src/processor/src/tests/unit/libs/agent_framework/test_groupchat_orchestrator_internals.py | Adjusts builder mocking to match the updated groupchat builder chaining API. |
| src/processor/src/tests/unit/libs/agent_framework/test_agent_builder.py | Updates expectations to match Agent construction via keyword params (vs nested default options). |
| src/processor/src/steps/migration_processor.py | Reverts workflow build pattern and switches streaming loop to workflow.run_stream(...). |
| src/processor/src/libs/base/orchestrator_base.py | Adjusts agent creation (store/context provider wiring) to match reverted context provider usage. |
| src/processor/src/libs/agent_framework/shared_memory_context_provider.py | Reverts provider lifecycle to invoking()/invoked() and changes memory injection to return a context object. |
| src/processor/src/libs/agent_framework/groupchat_orchestrator.py | Uses WorkflowBuilder as the groupchat builder and switches workflow streaming to run_stream. |
| src/processor/src/libs/agent_framework/azure_openai_response_retry.py | Removes orphan tool-message cleanup during context trimming and simplifies Azure endpoint kwarg handling. |
| src/processor/src/libs/agent_framework/agent_info.py | Changes tools typing/validation surface for AgentInfo. |
| src/processor/src/libs/agent_framework/agent_builder.py | Reverts Agent construction to pass model/options as direct kwargs rather than building ChatOptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #277