Skip to content

chore: Update RBAC Configuration to Reference Role IDs (follow-up)#308

Open
ShreyasW-Microsoft wants to merge 3 commits into
devfrom
psl-sw/rbac-role-ids
Open

chore: Update RBAC Configuration to Reference Role IDs (follow-up)#308
ShreyasW-Microsoft wants to merge 3 commits into
devfrom
psl-sw/rbac-role-ids

Conversation

@ShreyasW-Microsoft

@ShreyasW-Microsoft ShreyasW-Microsoft commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Purpose

Update the RBAC configuration so that every role assignment references its Azure built-in role definition ID (GUID) instead of the role display name. Referencing roles by GUID avoids ambiguity and intermittent lookup/deployment failures that can occur when resolving roles by display name.

Scope of changes:

  • infra/main.bicep — convert all roleDefinitionIdOrName role-name values to their role definition GUIDs (Storage Blob/Queue Data Contributor, DocumentDB Account Contributor, Cognitive Services OpenAI Contributor / User, App Configuration Data Reader, etc.), each annotated with an inline // Role Name comment.
  • infra/main_custom.bicep — same conversion, including the previously missed App Configuration Data Reader assignment.
  • infra/main.json — regenerated ARM output reflecting the above Bicep changes.
  • Inline role-name comments use the // Role Name format (space after //, no quotes) for readability and consistency with the rest of the files.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • Every roleDefinitionIdOrName across infra/main.bicep, infra/main_custom.bicep, and infra/main.json references a role definition GUID (no remaining display-name references).
  • Each GUID maps to the correct Azure built-in role (see the inline // Role Name comments).
  • infra/main.json is consistent with the regenerated Bicep.

Other Information

Companion change to the Content Processing Solution Accelerator PR applying the same role-ID convention.

Shreyas-Microsoft and others added 2 commits June 19, 2026 08:53
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the conversion of RBAC roleDefinitionIdOrName values from human-readable role names to role definition GUIDs in the infra Bicep templates (and regenerates the compiled ARM JSON), keeping role-name comments inline for readability.

Changes:

  • Replaced RBAC role name strings with role definition GUIDs across storage, Cosmos DB, AI services, and App Configuration role assignments.
  • Added inline comments in Bicep to preserve the original role names for readability.
  • Regenerated infra/main.json (Bicep generator version/hash updates + updated role assignment values).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
infra/main.json Regenerated compiled ARM template reflecting role GUID updates (and updated Bicep generator metadata).
infra/main.bicep Converts multiple role assignments to GUIDs and adds inline role-name comments.
infra/main_custom.bicep Converts multiple role assignments to GUIDs (including App Configuration Data Reader).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main_custom.bicep Outdated
roleAssignments: [
{
roleDefinitionIdOrName: 'Storage Blob Data Contributor'
roleDefinitionIdOrName: 'ba92f5b4-2d11-453d-a403-e96b0029c9fe' //'Storage Blob Data Contributor'
Comment thread infra/main.bicep Outdated
Comment thread infra/main.bicep Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants