chore: Update RBAC Configuration to Reference Role IDs (follow-up)#308
Open
ShreyasW-Microsoft wants to merge 3 commits into
Open
chore: Update RBAC Configuration to Reference Role IDs (follow-up)#308ShreyasW-Microsoft wants to merge 3 commits into
ShreyasW-Microsoft wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the conversion of RBAC roleDefinitionIdOrName values from human-readable role names to role definition GUIDs in the infra Bicep templates (and regenerates the compiled ARM JSON), keeping role-name comments inline for readability.
Changes:
- Replaced RBAC role name strings with role definition GUIDs across storage, Cosmos DB, AI services, and App Configuration role assignments.
- Added inline comments in Bicep to preserve the original role names for readability.
- Regenerated
infra/main.json(Bicep generator version/hash updates + updated role assignment values).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| infra/main.json | Regenerated compiled ARM template reflecting role GUID updates (and updated Bicep generator metadata). |
| infra/main.bicep | Converts multiple role assignments to GUIDs and adds inline role-name comments. |
| infra/main_custom.bicep | Converts multiple role assignments to GUIDs (including App Configuration Data Reader). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| roleAssignments: [ | ||
| { | ||
| roleDefinitionIdOrName: 'Storage Blob Data Contributor' | ||
| roleDefinitionIdOrName: 'ba92f5b4-2d11-453d-a403-e96b0029c9fe' //'Storage Blob Data Contributor' |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update the RBAC configuration so that every role assignment references its Azure built-in role definition ID (GUID) instead of the role display name. Referencing roles by GUID avoids ambiguity and intermittent lookup/deployment failures that can occur when resolving roles by display name.
Scope of changes:
infra/main.bicep— convert allroleDefinitionIdOrNamerole-name values to their role definition GUIDs (Storage Blob/Queue Data Contributor, DocumentDB Account Contributor, Cognitive Services OpenAI Contributor / User, App Configuration Data Reader, etc.), each annotated with an inline// Role Namecomment.infra/main_custom.bicep— same conversion, including the previously missedApp Configuration Data Readerassignment.infra/main.json— regenerated ARM output reflecting the above Bicep changes.// Role Nameformat (space after//, no quotes) for readability and consistency with the rest of the files.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
roleDefinitionIdOrNameacrossinfra/main.bicep,infra/main_custom.bicep, andinfra/main.jsonreferences a role definition GUID (no remaining display-name references).// Role Namecomments).infra/main.jsonis consistent with the regenerated Bicep.Other Information
Companion change to the Content Processing Solution Accelerator PR applying the same role-ID convention.