fix: update container registry module to reference VNet and DNS zone … - #326
Merged
Conversation
Akhileswara-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
July 17, 2026 12:44
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates infra/main.bicep to pass private networking resource IDs into the container registry module using module outputs (VNet subnet + Private DNS zone) instead of manually constructing those IDs, improving correctness and robustness (notably around case-sensitivity and exact resource ID formatting).
Changes:
- Updated
privateEndpointSubnetResourceIdto usevirtualNetwork.outputs.backendSubnetResourceIdwhen private networking is enabled. - Updated
privateDnsZoneResourceIdto useavmPrivateDnsZones[dnsZoneIndex.containerRegistry].outputs.resourceIdwhen private networking is enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avijit-Microsoft
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…outputs directly
Purpose
This pull request updates how the container registry module references resource IDs for private networking in
infra/main.bicep. Instead of manually constructing resource IDs, it now directly uses output values from the relevant modules, which helps avoid issues related to case sensitivity and ensures more reliable deployments.Networking resource ID references:
privateEndpointSubnetResourceIdto use the output from thevirtualNetworkmodule instead of constructing the resource ID manually, preventing case-sensitivity issues and accidental dependencies.privateDnsZoneResourceIdto use the output from theavmPrivateDnsZonesmodule, ensuring accurate and consistent resource ID references.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
Other Information
This pull request updates how resource IDs are referenced for the container registry's private networking configuration in
main.bicep. Instead of manually constructing resource IDs, the code now references the output values from the relevant modules directly. This change helps prevent case-sensitivity issues and ensures more robust and maintainable infrastructure code.Improvements to resource ID handling:
privateEndpointSubnetResourceIdto usevirtualNetwork.outputs.backendSubnetResourceIdinstead of constructing the resource ID manually.privateDnsZoneResourceIdto useavmPrivateDnsZones[dnsZoneIndex.containerRegistry].outputs.resourceIdinstead of constructing the resource ID manually.