Skip to content

fix: update container registry module to reference VNet and DNS zone … #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avijit-Microsoft merged 1 commit into from
Jul 17, 2026
Merged

fix: update container registry module to reference VNet and DNS zone … #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ module containerRegistry './modules/containerRegistry.bicep' = {
networkRuleBypassOptions: 'AzureServices'
// WAF: host the registry private endpoint in the backend subnet and link it
// to the privatelink.azurecr.io DNS zone so image pulls resolve privately.
// Use deterministic resource IDs here so non-private deployments do not
// pick up unconditional dependencies on the conditional network modules.
privateEndpointSubnetResourceId: enablePrivateNetworking ? resourceId(resourceGroup().name, 'Microsoft.Network/virtualNetworks/subnets', 'vnet-${solutionSuffix}', 'backend') : ''
privateDnsZoneResourceId: enablePrivateNetworking ? resourceId(resourceGroup().name, 'Microsoft.Network/privateDnsZones', 'privatelink.azurecr.io') : ''
// Reference the VNet and DNS zone outputs directly to avoid case-sensitivity
// issues with manually constructed resource IDs.
privateEndpointSubnetResourceId: enablePrivateNetworking ? virtualNetwork!.outputs.backendSubnetResourceId : ''
privateDnsZoneResourceId: enablePrivateNetworking ? avmPrivateDnsZones[dnsZoneIndex.containerRegistry]!.outputs.resourceId : ''
// Application managed identity gets AcrPull for identity-based image pulls.
acrPullPrincipalIds: [
appIdentity.outputs.principalId
Expand Down