refactor: rename get_async_azure_credential to build_async_azure_credential

Addresses Copilot review feedback on PR #915 (merged into dev). The two helpers get_azure_credential_async (async fn) and get_async_azure_credential (sync fn) differ only by word order, which is easy to confuse at call sites. Renaming the sync builder to build_async_azure_credential makes the sync-vs-async distinction explicit: build_ implies sync construction, async describes the returned credential type.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Copilot

src/api/helpers/azure_credential_utils.py

@@ -41,11 +41,12 @@ def get_azure_credential(client_id=None):
         return ManagedIdentityCredential(client_id=client_id)
 
 
-def get_async_azure_credential(client_id=None):
+def build_async_azure_credential(client_id=None):
     """
-    Synchronously returns an async Azure credential suitable for async SDK clients
-    (e.g., azure.cosmos.aio.CosmosClient). Mirrors get_azure_credential_async but
-    is callable from sync code paths.
+    Synchronously builds an async Azure credential suitable for async SDK clients
+    (e.g., azure.cosmos.aio.CosmosClient). Use this from sync constructors that
+    need to hand an async-capable credential to an async client; use
+    get_azure_credential_async() instead from `async with` blocks.
     """
     if os.getenv("APP_ENV", "prod").lower() == 'dev':
         return AioAzureCliCredential()

src/api/services/history_service.py

@@ -5,7 +5,7 @@
 from azure.ai.projects.aio import AIProjectClient
 from common.config.config import Config
 from common.database.cosmosdb_service import CosmosConversationClient
-from helpers.azure_credential_utils import get_azure_credential_async, get_async_azure_credential
+from helpers.azure_credential_utils import get_azure_credential_async, build_async_azure_credential
 
 from agent_framework.azure import AzureAIProjectAgentProvider
 
@@ -46,7 +46,7 @@ def init_cosmosdb_client(self):
 
             return CosmosConversationClient(
                 cosmosdb_endpoint=cosmos_endpoint,
-                credential=get_async_azure_credential(client_id=self.azure_client_id),
+                credential=build_async_azure_credential(client_id=self.azure_client_id),
                 database_name=self.azure_cosmosdb_database,
                 container_name=self.azure_cosmosdb_conversations_container,
                 enable_message_feedback=self.azure_cosmosdb_enable_feedback,