Skip to content

Commit 715ba55

Browse files
fix: Citation and Chat History panel independence (AB#43310)
2 parents 174a390 + c4486f2 commit 715ba55

2 files changed

Lines changed: 19 additions & 18 deletions

File tree

src/App/src/App.css

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
height: calc(100vh - var(--header-height));
1414
gap: var(--gap-base);
1515
margin-inline: var(--margin-base);
16+
overflow: hidden;
1617
}
1718

1819
.main-container > div {
@@ -51,21 +52,17 @@ body {
5152
font-weight: 400;
5253
}
5354

54-
.citation-overlay {
55-
position: fixed;
56-
top: var(--header-height);
57-
right: 0;
58-
width: 20%;
59-
min-width: 280px;
55+
.citation-panel-wrapper {
56+
flex: 0 1 20%;
57+
min-width: 200px;
6058
max-width: 400px;
61-
height: calc(100vh - var(--header-height));
62-
z-index: 100;
63-
pointer-events: none;
64-
box-sizing: border-box;
59+
margin-block: var(--margin-base);
60+
overflow: hidden;
6561
}
6662

67-
.citation-overlay > * {
68-
pointer-events: auto;
63+
.citation-panel-wrapper .citationPanel {
64+
height: 100%;
65+
box-sizing: border-box;
6966
}
7067

7168
.left-section {

src/App/src/App.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,14 @@ const Dashboard: React.FC = () => {
166166
nextState[panels.CHAT] = true;
167167
}
168168

169+
if (panelName === panels.CHAT && !nextState[panels.CHAT]) {
170+
dispatch(hideCitation());
171+
}
172+
169173
updateLayoutWidths(nextState);
170174
setPanelShowStates(nextState);
171175
},
172-
[panelShowStates, updateLayoutWidths]
176+
[dispatch, panelShowStates, updateLayoutWidths]
173177
);
174178

175179
const getHistoryListData = useCallback(async () => {
@@ -302,6 +306,11 @@ const Dashboard: React.FC = () => {
302306
/>
303307
</div>
304308
)}
309+
{showCitation && currentConversationIdForCitation !== "" && (
310+
<div className="citation-panel-wrapper">
311+
<CitationPanel activeCitation={activeCitation} />
312+
</div>
313+
)}
305314
{panelShowStates[panels.CHAT] &&
306315
panelShowStates[panels.CHATHISTORY] && (
307316
<div
@@ -322,11 +331,6 @@ const Dashboard: React.FC = () => {
322331
</div>
323332
)}
324333
</div>
325-
{showCitation && currentConversationIdForCitation !== "" && (
326-
<section className="citation-overlay" aria-label="Citation panel">
327-
<CitationPanel activeCitation={activeCitation} />
328-
</section>
329-
)}
330334
</FluentProvider>
331335
);
332336
};

0 commit comments

Comments
 (0)