fix: Removing the dependency on Azure Key Vault & Truncate SQL response#361
Merged
Conversation
Avijit-Microsoft
approved these changes
Apr 15, 2025
Contributor
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes significant changes to the infrastructure deployment scripts and the backend configuration. The key changes involve removing the dependency on Azure Key Vault for secret management and updating the Dockerfile for the API application.
Infrastructure Deployment Changes:
infra/deploy_backend_docker.bicep: Added new secure parameters forazureOpenAIKey,azureAiProjectConnString, andazureSearchAdminKey, and removed thekeyVaultNameparameter. Updated theappServicemodule to use these new parameters. [1] [2]infra/main.bicep: Updated thebackend_dockermodule to retrieve secrets directly from Key Vault usinggetSecretinstead of passing thekeyVaultName. Removed thekeyVaultNameparameter. [1] [2]Removal of Key Vault Role Assignments:
infra/deploy_backend_docker.bicep: Removed resources related to Key Vault role assignments.infra/main.json: Removed Key Vault role assignment resources and updated the deployment template to use the new secure parameters for secrets. [1] [2] [3]Dockerfile Updates:
src/api/ApiApp.Dockerfile: Added new dependencies (opus-devandlibvpx-dev). Upgraded pip and setuptools before installing Python dependencies. [1] [2]Backend Configuration Changes:
src/api/common/config/config.py: Removed the initialization of the Key Vault client and theget_secretmethod. Updated the configuration to retrieve secrets directly from environment variables. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation