Skip to content

fix: Removing the dependency on Azure Key Vault & Truncate SQL response#361

Merged
Avijit-Microsoft merged 2 commits into
devfrom
psl-pk-truncatemessage
Apr 15, 2025
Merged

fix: Removing the dependency on Azure Key Vault & Truncate SQL response#361
Avijit-Microsoft merged 2 commits into
devfrom
psl-pk-truncatemessage

Conversation

@Pavan-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request includes significant changes to the infrastructure deployment scripts and the backend configuration. The key changes involve removing the dependency on Azure Key Vault for secret management and updating the Dockerfile for the API application.

Infrastructure Deployment Changes:

  • infra/deploy_backend_docker.bicep: Added new secure parameters for azureOpenAIKey, azureAiProjectConnString, and azureSearchAdminKey, and removed the keyVaultName parameter. Updated the appService module to use these new parameters. [1] [2]
  • infra/main.bicep: Updated the backend_docker module to retrieve secrets directly from Key Vault using getSecret instead of passing the keyVaultName. Removed the keyVaultName parameter. [1] [2]

Removal of Key Vault Role Assignments:

Dockerfile Updates:

Backend Configuration Changes:

  • src/api/common/config/config.py: Removed the initialization of the Key Vault client and the get_secret method. Updated the configuration to retrieve secrets directly from environment variables. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

@Avijit-Microsoft Avijit-Microsoft merged commit e74a88b into dev Apr 15, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Pavan-Microsoft Pavan-Microsoft deleted the psl-pk-truncatemessage branch April 17, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants