feat: process KM sample data manually as part of post-deployment activity#363
Merged
Merged
Conversation
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
brittneek
as code owners
Avijit-Microsoft
approved these changes
Apr 17, 2025
Contributor
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several updates to the automation scripts for managing Azure resources. The changes focus on improving authentication mechanisms, enhancing script robustness, and ensuring better role assignments. Below is a summary of the most important changes:
Authentication Improvements:
infra/scripts/add_user_scripts/create-sql-user-and-role.ps1: Updated the script to use Azure AD authentication instead of the owner-managed identity for SQL database tasks. Introduced a switch parameter$UseManagedIdentityfor flexible authentication options. [1] [2] [3]Role Assignments:
infra/scripts/copy_kb_files.sh: Added logic to check and assign the "Storage Blob Data Contributor" and "Key Vault Secrets User" roles to the signed-in user if not already assigned.Script Enhancements:
infra/scripts/index_scripts/*.py: Modified the scripts to acceptkey_vault_nameandmanaged_identity_client_idas command-line arguments, replacing hardcoded values. [1] [2] [3] [4]New Script:
infra/scripts/process_sample_data.sh: Added a new script to streamline the process of copying KB files, creating indexes, and setting up SQL users and roles. This script includes error handling and logging for better traceability.Script Refactoring:
infra/scripts/run_create_index_scripts.sh: Refactored to remove hardcoded URLs, added authentication checks, and ensured the creation of a virtual environment for Python dependencies.Does this introduce a breaking change?
No
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information