fix: Fix CodeQL issue#367
Merged
Merged
Conversation
Avijit-Microsoft
approved these changes
Apr 16, 2025
Contributor
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on improving error logging and response messages in the
src/api/api/api_routes.pyandsrc/api/api/history_routes.pyfiles. The key changes include enhancing the logging of exceptions and standardizing the error messages returned in JSON responses.Improvements to error logging and response messages:
src/api/api/api_routes.py: Enhanced exception logging by including the exception message in the log and standardized the error messages returned in JSON responses for multiple endpoints, such asfetch_chart_data,fetch_chart_data_with_filters,fetch_filter_data,conversation, andget_layout_config. [1] [2] [3] [4] [5]src/api/api/history_routes.py: Improved exception logging by including the exception message in the log and standardized the error messages returned in JSON responses for various endpoints, includingadd_conversation,update_conversation,update_message_feedback,delete_conversation,list_conversations,get_conversation_messages,rename_conversation,delete_all_conversations,clear_messages, andensure_cosmos. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation