feat: Publish Local Build Container to Azure Container Registry - [dev to main] by Pavan-Microsoft · Pull Request #487 · microsoft/Conversation-Knowledge-Mining-Solution-Accelerator

Pavan-Microsoft · 2025-06-12T11:05:37Z

Purpose

This pull request introduces several changes across multiple files to support local builds with Docker, streamline infrastructure deployment, and enhance configuration flexibility. The most significant updates include adding support for a "use local build" flag, refactoring container registry management, and removing unused resources from the infrastructure definition.

Support for Local Builds

Added a useLocalBuild parameter to multiple Bicep files (infra/main.bicep, infra/deploy_app_service.bicep, infra/deploy_backend_docker.bicep, infra/deploy_frontend_docker.bicep) to conditionally configure deployments for local Docker builds. This includes setting up role assignments for pulling images from a local Azure Container Registry (ACR). [1] [2] [3]

Container Registry Management

Refactored container registry handling by introducing a new deploy_container_registry.bicep file to define the ACR resource. This replaces inline definitions in other files and centralizes ACR creation logic.
Updated image references in backend and frontend deployment files to dynamically use either a local or default ACR based on the useLocalBuild flag. [1] [2]

Removal of Unused Resources

Removed definitions for unused resources, such as storage accounts, container registries, and role assignments, from infra/deploy_ai_foundry.bicep. This simplifies the infrastructure and eliminates unnecessary components. [1] [2] [3]

Preprovision Hooks

Added preprovision hooks in azure.yaml to handle Docker build scripts for both Windows (docker-build.ps1) and POSIX (docker-build.sh) environments. These scripts are executed during deployment to prepare the environment.

Devcontainer Updates

Updated the .devcontainer/devcontainer.json file to include the docker-in-docker feature, enabling Docker builds within the development container.

These changes enhance the flexibility and maintainability of the deployment pipeline while improving support for local development workflows.

Does this introduce a breaking change?

Yes
No

Golden Path Validation

I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify docker image pointing to your local image when use_Local_Build environment variable is set to true

…edge-Mining-Solution-Accelerator into psl-pk-US18489-localacr

feat: Publish Locally Built Container Image to Azure Container Registry

Copilot

Pull Request Overview

This PR adds support for local Docker builds via a new useLocalBuild flag, centralizes ACR creation, removes unused infra resources, enhances E2E test reporting, and updates the devcontainer for Docker-in-Docker.

Introduce useLocalBuild param in Bicep modules to switch ACR references and role assignments
Extract ACR resource into deploy_container_registry.bicep and update build scripts (docker-build.sh/ps1)
Enhance pytest HTML reporting in conftest.py and enable Docker DIND in .devcontainer

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/e2e-test/tests/conftest.py	Capture per-test logs, rename Duration column, and customize node IDs
tests/e2e-test/testdata/prompts.json	Added a new prompt entry
tests/e2e-test/sample_dotenv_file.txt	Fixed mismatched quotes
tests/e2e-test/requirements.txt	Added `beautifulsoup4` dependency
tests/e2e-test/pytest.ini	Enabled short tracebacks
tests/e2e-test/pages/HomePage.py	Extended page object with citation link methods
infra/scripts/docker-build.sh/.ps1	Added local-build toggle, ACR deploy/login, build & push logic
infra/*.bicep & infra/main.json	Added `useLocalBuild`, dynamic `acrName`, removed unused resources
infra/deploy_container_registry.bicep	New module for ACR creation
azure.yaml	Added preprovision hooks to run Docker build scripts
.devcontainer/devcontainer.json	Enabled Docker-in-Docker feature

Copilot · 2025-06-12T11:38:31Z

 @pytest.hookimpl(tryfirst=True)
-def pytest_html_report_title(report):
-    report.title = "Automation_KM_Generic"
+def pytest_runtest_setup(item):


[nitpick] Attaching a handler to the root logger may capture unrelated logs. Consider using a dedicated logger instance scoped to this fixture to avoid noise from other modules.

Copilot · 2025-06-12T11:38:31Z

+    else:
+        report.description = ""
+
+def pytest_collection_modifyitems(items):


[nitpick] Modifying the private attribute item._nodeid can be brittle across Pytest versions. Consider using the public item.name or a reporting hook to adjust the display name.

Copilot · 2025-06-12T11:38:31Z

+def rename_duration_column():
+    report_path = os.path.abspath("report.html")  # or your report filename


[nitpick] Hardcoding the report filename may break if the --html option changes; consider retrieving the path from Pytest config or an environment variable.

Suggested change

def rename_duration_column():

report_path = os.path.abspath("report.html") # or your report filename

report_filename = None # Global variable to store the report filename

def pytest_configure(config):

global report_filename

report_filename = config.getoption("--html") # Retrieve the --html option value

def rename_duration_column():

if not report_filename:

print("Report filename not set, skipping column rename.")

return

report_path = os.path.abspath(report_filename)

github-actions · 2025-06-12T12:14:44Z

🎉 This PR is included in version 3.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Pavan-Microsoft and others added 15 commits May 28, 2025 17:59

Publish Local Build Container to Azure Container Registry

34ac8c3

add useLocalBuild parameter

adca8f7

Merge branch 'dev' of https://github.com/microsoft/Conversation-Knowl…

655fa97

…edge-Mining-Solution-Accelerator into psl-pk-US18489-localacr

Add role to local continer registry

13dea90

local build shell script

8c294d0

Merge branch 'dev' of https://github.com/microsoft/Conversation-Knowl…

97b382d

…edge-Mining-Solution-Accelerator into psl-pk-US18489-localacr

fix local container permission issue

3531b05

Merge branch 'dev' of https://github.com/microsoft/Conversation-Knowl…

f32650b

…edge-Mining-Solution-Accelerator into psl-pk-US18489-localacr

updated main.json

439e381

fix parameter issue in docker-build.sh

be514b2

docker extension

4226ff4

Remove unused storage account

4354069

Merge pull request #485 from microsoft/psl-pk-US18489-localacr

adab8fe

feat: Publish Locally Built Container Image to Azure Container Registry

added logs with time

68d603b

test: Implemented Log execution time per prompt in Report for KM generic

a249d16

Pavan-Microsoft requested review from Avijit-Microsoft, Prajwal-Microsoft, Roopan-Microsoft, Vinay-Microsoft, aniaroramsft and brittneek as code owners June 12, 2025 11:05

Pavan-Microsoft changed the title ~~feat: Publish Local Build Container to Azure Container Registry~~ feat: Publish Local Build Container to Azure Container Registry - [dev to main] Jun 12, 2025

Prajwal-Microsoft approved these changes Jun 12, 2025

View reviewed changes

Prajwal-Microsoft requested a review from Copilot June 12, 2025 11:36

Copilot AI reviewed Jun 12, 2025

View reviewed changes

fix: Typographical error: 'deplpoying' should be 'deploying'.

98d619f

Prajwal-Microsoft approved these changes Jun 12, 2025

View reviewed changes

Pavan-Microsoft merged commit e5bb003 into main Jun 12, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Publish Local Build Container to Azure Container Registry - [dev to main]#487

feat: Publish Local Build Container to Azure Container Registry - [dev to main]#487
Pavan-Microsoft merged 16 commits into
mainfrom
dev

Pavan-Microsoft commented Jun 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jun 12, 2025

Uh oh!

Copilot AI Jun 12, 2025

Uh oh!

Copilot AI Jun 12, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		def rename_duration_column():
		report_path = os.path.abspath("report.html") # or your report filename

-def rename_duration_column():
-    report_path = os.path.abspath("report.html")  # or your report filename
+report_filename = None  # Global variable to store the report filename
+def pytest_configure(config):
+    global report_filename
+    report_filename = config.getoption("--html")  # Retrieve the --html option value
+def rename_duration_column():
+    if not report_filename:
+        print("Report filename not set, skipping column rename.")
+        return
+    report_path = os.path.abspath(report_filename)

Uh oh!

Conversation

Pavan-Microsoft commented Jun 12, 2025

Purpose

Support for Local Builds

Container Registry Management

Removal of Unused Resources

Preprovision Hooks

Devcontainer Updates

Does this introduce a breaking change?

Golden Path Validation

Deployment Validation

What to Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants