Skip to content

ci: fix deployment pipeline#590

Merged
Roopan-Microsoft merged 3 commits into
mainfrom
deploy-pipeline-fix
Sep 15, 2025
Merged

ci: fix deployment pipeline#590
Roopan-Microsoft merged 3 commits into
mainfrom
deploy-pipeline-fix

Conversation

@Harsh-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the deployment workflow and related infrastructure configuration to improve branch handling, deployment tagging, and resource tagging. The changes enhance how branch names are determined during workflow runs, simplify tag assignment logic, and add a security tag to deployments.

Workflow improvements:

  • Updated the BRANCH_NAME environment variable in .github/workflows/deploy-KMGeneric.yml to use github.event.workflow_run.head_branch as the primary source, falling back to other branch references for more robust branch detection during workflow runs.

Deployment logic simplification:

  • Simplified the tag assignment logic in the Determine Tag Name Based on Branch step, ensuring that branches not explicitly handled default to latest_fdp instead of using the head ref or a generic default.

Resource tagging:

  • Added a tags parameter with {'SecurityControl':'Ignore'} to the Azure deployment command in .github/workflows/deploy-KMGeneric.yml to improve resource management and tracking.

Infrastructure configuration:

  • Removed minimum and maximum length constraints from the solutionName parameter in infra/deploy_app_service.bicep, allowing more flexibility in solution naming.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 564228f into main Sep 15, 2025
9 of 10 checks passed
@Harsh-Microsoft Harsh-Microsoft deleted the deploy-pipeline-fix branch September 16, 2025 08:39
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants