From 7e98a192cbd95d89cc8d683307cd1d842b6ad758 Mon Sep 17 00:00:00 2001 From: Harsh-Microsoft Date: Mon, 15 Sep 2025 16:06:34 +0530 Subject: [PATCH 1/3] ci: Add tags parameter to deployment command in workflow --- .github/workflows/deploy-KMGeneric.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy-KMGeneric.yml b/.github/workflows/deploy-KMGeneric.yml index 5059f40b4..d3064848a 100644 --- a/.github/workflows/deploy-KMGeneric.yml +++ b/.github/workflows/deploy-KMGeneric.yml @@ -120,7 +120,7 @@ jobs: az deployment group create \ --resource-group ${{ env.RESOURCE_GROUP_NAME }} \ --template-file infra/main.bicep \ - --parameters solutionName=${{env.SOLUTION_PREFIX}} contentUnderstandingLocation="swedencentral" secondaryLocation="${{ env.AZURE_LOCATION }}" imageTag=${{ steps.determine_tag.outputs.tagname }} gptDeploymentCapacity=150 aiDeploymentsLocation="${{ env.AZURE_LOCATION }}" createdBy="Pipeline" + --parameters solutionName=${{env.SOLUTION_PREFIX}} contentUnderstandingLocation="swedencentral" secondaryLocation="${{ env.AZURE_LOCATION }}" imageTag=${{ steps.determine_tag.outputs.tagname }} gptDeploymentCapacity=150 aiDeploymentsLocation="${{ env.AZURE_LOCATION }}" createdBy="Pipeline" tags="{'SecurityControl':'Ignore'}" From 74e7e88606b2c1dd0259e2a6d7f87736b08407fe Mon Sep 17 00:00:00 2001 From: Harsh-Microsoft Date: Mon, 15 Sep 2025 16:50:24 +0530 Subject: [PATCH 2/3] remove length constraints from solutionName parameter in deploy_app_service.bicep --- infra/deploy_app_service.bicep | 2 -- 1 file changed, 2 deletions(-) diff --git a/infra/deploy_app_service.bicep b/infra/deploy_app_service.bicep index e8928a535..4a9e6fac6 100644 --- a/infra/deploy_app_service.bicep +++ b/infra/deploy_app_service.bicep @@ -1,8 +1,6 @@ // ========== Key Vault ========== // targetScope = 'resourceGroup' -@minLength(3) -@maxLength(16) @description('Required. Contains Solution Name.') param solutionName string From 310b5b44e46012ed01ab6b8095720adb68b32091 Mon Sep 17 00:00:00 2001 From: Harsh-Microsoft Date: Mon, 15 Sep 2025 17:11:40 +0530 Subject: [PATCH 3/3] ci: Update BRANCH_NAME and tagname logic for improved branch handling in deployment workflow --- .github/workflows/deploy-KMGeneric.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-KMGeneric.yml b/.github/workflows/deploy-KMGeneric.yml index d3064848a..8cf076332 100644 --- a/.github/workflows/deploy-KMGeneric.yml +++ b/.github/workflows/deploy-KMGeneric.yml @@ -14,7 +14,7 @@ on: env: GPT_MIN_CAPACITY: 150 TEXT_EMBEDDING_MIN_CAPACITY: 80 - BRANCH_NAME: ${{ github.head_ref || github.ref_name }} + BRANCH_NAME: ${{ github.event.workflow_run.head_branch || github.head_ref || github.ref_name }} jobs: deploy: runs-on: ubuntu-latest @@ -112,7 +112,7 @@ jobs: echo "Generated SOLUTION_PREFIX: ${UNIQUE_SOLUTION_PREFIX}" - name: Determine Tag Name Based on Branch id: determine_tag - run: echo "tagname=${{ github.ref_name == 'main' && 'latest_fdp' || github.ref_name == 'dev' && 'dev' || github.ref_name == 'demo' && 'demo' || github.ref_name == 'dependabotchanges' && 'dependabotchanges' || github.head_ref || 'default' }}" >> $GITHUB_OUTPUT + run: echo "tagname=${{ github.ref_name == 'main' && 'latest_fdp' || github.ref_name == 'dev' && 'dev' || github.ref_name == 'demo' && 'demo' || github.ref_name == 'dependabotchanges' && 'dependabotchanges' || 'latest_fdp' }}" >> $GITHUB_OUTPUT - name: Deploy Bicep Template id: deploy run: |