fix: audio data folder name consistency#677
Merged
Merged
Conversation
Ragini-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
nchandhi and
toherman-msft
as code owners
December 4, 2025 06:03
Avijit-Microsoft
approved these changes
Dec 4, 2025
Contributor
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment scripts and related Bicep module to simplify argument passing and fix a folder naming issue. The main changes involve removing an unused
fileSystemargument, updating the order of script arguments, and correcting a folder name in the extraction process.Deployment script argument changes:
The
uploadFilesBicep module ininfra/main.bicepnow omits thedataargument and reorders the remaining arguments passed to the deployment script, reflecting the removal of the unused parameter.Both
infra/scripts/copy_kb_files.shandinfra/scripts/copy_kb_files_manual.shhave been updated to remove thefileSystemvariable, and the order of remaining arguments has been adjusted to match the new invocation from Bicep. [1] [2]Bug fix:
infra/scripts/copy_kb_files.sh, the folder name for extracting audio data has been corrected fromaudiodatatoaudio_datato match the zip file contents.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information