Skip to content

fix: merging dev changes to main#682

Merged
Avijit-Microsoft merged 7 commits into
mainfrom
dev
Dec 8, 2025
Merged

fix: merging dev changes to main#682
Avijit-Microsoft merged 7 commits into
mainfrom
dev

Conversation

@Priyanka-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

  • ...
    This pull request focuses on improving the efficiency and robustness of agent creation in the codebase by ensuring that agents are reused when possible, rather than always creating new instances. It also enhances logging for better traceability and error handling. Additionally, there are minor fixes to deployment scripts and variable handling.

Agent creation and reuse improvements:

  • Updated all agent factory classes (ChartAgentFactory, SQLAgentFactory, SearchAgentFactory, and ConversationAgentFactory) to first check for an existing agent with the expected name and reuse it if found, only creating a new agent if necessary. This reduces unnecessary agent duplication and improves resource usage. [1] [2] [3] [4]
  • Added detailed logging to all agent factories to record when agents are reused or newly created, and to capture errors when listing agents fails. [1] [2] [3] [4] [5]

Documentation and code clarity:

  • Improved docstrings in agent factory methods to clarify that agents are now reused if possible, and only created if not found. [1] [2] F0fc4e61L8R13, F707f7a8L15R21)

Deployment and script fixes:

  • Fixed argument order and removed unused variables in deployment scripts (copy_kb_files.sh, copy_kb_files_manual.sh), and updated the corresponding Bicep module to match the new argument order. Also corrected a folder name in the extraction step. [1] [2] [3]

Consistency improvements:

  • Standardized agent naming conventions across all factories to ensure consistent reuse logic. [1] [2] [3] [4]

Error handling:

  • Improved error logging in the agent deletion process to use the logger instead of print statements.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Avijit-Microsoft
Avijit-Microsoft merged commit fa6a652 into main Dec 8, 2025
10 checks passed
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants