fix: merging dev changes to main#682
Merged
Merged
Conversation
…art, Conversation, Search, and SQL factories
…rt, Conversation, Search, and SQL factories
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
December 8, 2025 05:27
Avijit-Microsoft
approved these changes
Dec 8, 2025
Contributor
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on improving the efficiency and robustness of agent creation in the codebase by ensuring that agents are reused when possible, rather than always creating new instances. It also enhances logging for better traceability and error handling. Additionally, there are minor fixes to deployment scripts and variable handling.
Agent creation and reuse improvements:
ChartAgentFactory,SQLAgentFactory,SearchAgentFactory, andConversationAgentFactory) to first check for an existing agent with the expected name and reuse it if found, only creating a new agent if necessary. This reduces unnecessary agent duplication and improves resource usage. [1] [2] [3] [4]Documentation and code clarity:
Deployment and script fixes:
copy_kb_files.sh,copy_kb_files_manual.sh), and updated the corresponding Bicep module to match the new argument order. Also corrected a folder name in the extraction step. [1] [2] [3]Consistency improvements:
Error handling:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information