Skip to content

fix: Remove unused favicon files and update HTML and manifest references #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akhileswara-Microsoft wants to merge 7 commits into from
Closed

fix: Remove unused favicon files and update HTML and manifest references #817

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0f859b
fix: remove unused favicon files and update references in HTML and ma…
Akhileswara-Microsoft Mar 18, 2026
36e8053
Potential fix for pull request finding
Akhileswara-Microsoft Mar 18, 2026
9ded8f4
fix: remove unused apple-touch-icon and update favicon references in …
Akhileswara-Microsoft Mar 18, 2026
8e92291
Merge branch 'remove-unused-favicons_Akhileswar' of https://github.co…
Akhileswara-Microsoft Mar 18, 2026
90b4030
Potential fix for pull request finding
Akhileswara-Microsoft Mar 18, 2026
8af653e
fix: update favicon link in index.html to use a valid base64 image
Akhileswara-Microsoft Mar 19, 2026
2550699
fix: remove unused favicon link from index.html
Akhileswara-Microsoft Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed src/App/public/apple-touch-icon.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/App/public/favicon-16x16.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/App/public/favicon-32x32.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/App/public/favicon.ico
View file
Open in desktop
Binary file not shown.
15 changes: 2 additions & 13 deletions src/App/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,18 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
<meta
name="description"
content="Web site created using create-react-app"
/>
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
-->
<!-- <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png" />
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png" /> -->
<!-- <link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> -->
<!-- <link rel="manifest" href="/site.webmanifest"> -->
<link rel="icon" href="data:,">
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
Outdated
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
Outdated

<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
Outdated
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
Outdated
<title>KM-Generic</title>
Expand Down
19 changes: 2 additions & 17 deletions src/App/public/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,14 @@
"name": "Knowledge Mining Generic",
"icons": [
{
"src": "favicon.ico",
"sizes": "64x64 32x32 24x24 16x16",
"type": "image/x-icon"
},
{
"src": "/android-chrome-192x192.png",
"src": "android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
},
{
"src": "/android-chrome-512x512.png",
"src": "android-chrome-512x512.png",
"sizes": "512x512",
"type": "image/png"
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
},
{
"src": "/favicon-16x16.png",
"sizes": "16x16",
"type": "image/png"
},
{
"src": "/favicon-32x32.png",
"sizes": "32x32",
"type": "image/png"
}
],
"start_url": ".",
Expand Down
Binary file removed src/favicon-16x16.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/favicon-32x32.png
View file
Open in desktop
Binary file not shown.
19 changes: 2 additions & 17 deletions src/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,14 @@
"name": "Knowledge Mining Generic",
"icons": [
{
"src": "favicon.ico",
"sizes": "64x64 32x32 24x24 16x16",
"type": "image/x-icon"
},
{
"src": "/android-chrome-192x192.png",
"src": "android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
},
{
"src": "/android-chrome-512x512.png",
"src": "android-chrome-512x512.png",
"sizes": "512x512",
"type": "image/png"
Comment thread
Akhileswara-Microsoft marked this conversation as resolved.
Comment on lines 5 to 13
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/manifest.json now references android-chrome-192x192.png and android-chrome-512x512.png as relative paths, but those files don’t exist alongside this manifest (they appear to live under src/App/public/). If this manifest is still used anywhere, its icons will 404; either copy the PNGs to the same directory, adjust the paths to wherever they’re actually served from, or remove this duplicate manifest if it’s unused.

Copilot uses AI. Check for mistakes.
},
{
"src": "/favicon-16x16.png",
"sizes": "16x16",
"type": "image/png"
},
{
"src": "/favicon-32x32.png",
"sizes": "32x32",
"type": "image/png"
}
],
"start_url": ".",
Expand Down
Loading