fix: codeql issue fix - add function to determine if span name contains a Cosmos DB host#825
Merged
Merged
Conversation
Avijit-Microsoft
approved these changes
Mar 20, 2026
Contributor
|
🎉 This PR is included in version 3.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a more robust method for detecting Cosmos DB spans in the logging span filter logic. The main improvement is the addition of a dedicated function to safely parse and identify Cosmos DB hosts, replacing less reliable string matching. This enhances the accuracy and maintainability of span filtering.
Improvements to Cosmos DB span detection:
_is_cosmos_hostfunction to safely parse span names and determine if they reference a Cosmos DB host, usingurlparsefor improved reliability.DropASGIResponseBodySpanProcessor.on_endto use_is_cosmos_hostinstead of direct string matching, ensuring more accurate identification of Cosmos DB spans.Dependency and import updates:
urlparsefromurllib.parseto support robust span name parsing.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation