fix: dev to main - Add location parameter to AI search service and update package versions, improvements to local development setup#876
Merged
Conversation
fix: add location parameter to AI search service update module
… in requirements.txt
fix: update package versions in requirements and package files
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates application and script dependencies and adjusts the infrastructure templates to improve AI Search deployment parameterization (adding location) and deployment ordering.
Changes:
- Bumps Python dependencies (API + infra scripts) and updates frontend overrides/lockfile for lodash.
- Adds/passes
locationto the AI Search AVM module invocation in Bicep and the generated ARM template. - Reorders some
dependsOnentries ininfra/main.jsonand updates the generated template hash.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/api/requirements.txt | Updates pinned Python dependency versions (requests/types-requests/aiohttp/pytest). |
| infra/scripts/agent_scripts/requirements.txt | Bumps aiohttp for agent scripts. |
| infra/scripts/index_scripts/requirements.txt | Bumps pypdf for indexing scripts. |
| src/App/package.json | Adds a lodash override version. |
| src/App/package-lock.json | Updates resolved lodash package version in lockfile. |
| infra/main.bicep | Passes location into searchServiceUpdate module params. |
| infra/main_custom.bicep | Passes location into searchServiceUpdate module params. |
| infra/main.json | Reflects Bicep changes: templateHash update, location param passed to module, dependency ordering tweaks. |
Files not reviewed (1)
- src/App/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: add dependency on searchService in searchServiceUpdate module
Avijit-Microsoft
approved these changes
Apr 20, 2026
Contributor
|
🎉 This PR is included in version 3.21.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements to local development setup, infrastructure automation, dependency updates, and documentation. The main focus is on enhancing the developer experience by providing robust startup scripts for both Windows and Unix-like systems, improving environment and process management, updating dependencies for better security and compatibility, and refining infrastructure deployment scripts.
Local Development Experience Improvements:
start.cmdfor Windows andstart.shfor macOS/Linux/WSL) that handle environment setup, dependency installation, Azure authentication, and starting backend/frontend servers, including automatic cleanup of processes on exit or interruption. The documentation (LocalDevelopmentSetup.md) was updated to reflect these changes and provide clear instructions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Dependency Updates:
aiohttp,requests,pytest,pypdf, andlodash. [1] [2] [3] [4] [5] [6]Infrastructure and Automation Enhancements:
locationparameter to the search service module, refining resource dependency ordering, and ensuring proper deployment sequencing. [1] [2] [3] [4] [5] [6] [7]Azure Role Assignment and Access:
az cosmosdb sql role assignment createcommand and clarified variable usage for improved reliability.These changes collectively streamline the local development workflow, improve reliability and cross-platform support, and keep dependencies and infrastructure scripts up-to-date.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation