fix: increase e2e test timeouts and improve app readiness check#928
Open
Dhanushree-Microsoft wants to merge 1 commit into
Open
fix: increase e2e test timeouts and improve app readiness check#928Dhanushree-Microsoft wants to merge 1 commit into
Dhanushree-Microsoft wants to merge 1 commit into
Conversation
- Increase home_page_load timeout to 180s (explicit instead of relying on default) - Increase show_chat_history timeout from 9s to 60s to handle slow backend responses - Improve workflow health check with HTTP status code validation and 15 attempts - Add 30s post-ready wait for full app initialization - Increase retry delays between test runs (60s and 90s instead of 30s and 60s) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dhanushree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize the Golden Path E2E pipeline by accommodating slower application startup and slower backend/UI responsiveness during test execution.
Changes:
- Increased Playwright wait timeouts in
HomePagepage-object methods to reduce flaky failures under load. - Improved GitHub Actions “app readiness” polling to validate HTTP status codes, allow more attempts, and add an extra post-ready wait.
- Increased retry backoff delays between test reruns to give the app more time to recover.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/e2e-test/pages/HomePage.py |
Raises key UI wait timeouts for initial page readiness and chat history visibility. |
.github/workflows/job-test-automation.yml |
Enhances readiness polling and increases delays between retry test runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Attempt $attempt: Checking if application is ready..." | ||
| if curl -f -s "${{ env.url }}" > /dev/null; then | ||
| echo "Application is ready!" | ||
| HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" "${{ env.url }}" || echo "000") |
Comment on lines
+149
to
152
| - name: Sleep for 60 seconds | ||
| if: ${{ steps.test1.outcome == 'failure' }} | ||
| run: sleep 30s | ||
| run: sleep 60s | ||
| shell: bash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The e2e Golden Path test pipeline is failing consistently due to timeout errors:
The app appears to be slow/unresponsive when the tests execute, causing all 3 retry attempts to fail.
Changes
\ ests/e2e-test/pages/HomePage.py\
.github/workflows/job-test-automation.yml\
Related
Fixes pipeline failure: https://github.com/microsoft/Conversation-Knowledge-Mining-Solution-Accelerator/actions/runs/26271281861