fix: configure Vite CSS modules to match CRA class naming convention#930
Open
Dhanushree-Microsoft wants to merge 1 commit into
Open
fix: configure Vite CSS modules to match CRA class naming convention#930Dhanushree-Microsoft wants to merge 1 commit into
Dhanushree-Microsoft wants to merge 1 commit into
Conversation
The Vite migration changed CSS module class name generation from CRA's format ([name]_[local]__[hash]) to Vite's default format (_[local]_[hash]). This broke e2e test locators that rely on class names containing the component filename prefix (e.g., 'ChatHistoryListItemCell_chatTitle'). Add generateScopedName config to produce CRA-compatible class names, ensuring existing e2e tests continue to work without modification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dhanushree-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Dhanushree-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores Create React App–style CSS Module class name generation in the Vite-based frontend build so existing e2e selectors (that depend on the filename-prefixed class name) continue to work after the Vite migration.
Changes:
- Configure
css.modules.generateScopedNamein Vite to emit[name]_[local]__[hash:base64:5]class names (CRA-compatible). - Align generated CSS module class naming with existing e2e test expectations to unblock pipeline failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Vite migration (part of PR #922) changed how CSS module class names are generated.
The e2e test locator //div[contains(@Class, 'ChatHistoryListItemCell_chatTitle')]\ expects the CRA format with the filename prefix. With Vite's default naming, the locator can't find the element → test fails with:
\
AssertionError: Chat history name was not visible on the page within the expected time.
\\
Fix
Added \css.modules.generateScopedName\ to \�ite.config.ts\ to produce CRA-compatible class names:
\\ s
css: {
modules: {
generateScopedName: '[name]_[local]__[hash:base64:5]',
},
},
\\
Related