Skip to content

Commit 1bf3b12

Browse files
committed
Add CS1591 to WarningsNotAsErrors
Add CS1591 to the WarningsNotAsErrors list in src/Projections/Directory.Build.props so missing XML comment warnings (e.g. for CoreDragDropManager) are not treated as build errors. Also update the nearby comment block to document the CS1591 entry.
1 parent 08e04b6 commit 1bf3b12

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/Projections/Directory.Build.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@
77
"CS0109: The member 'IChatMessage2.Status' does not hide an accessible member. The new keyword is not required."
88
"CS0114: 'IUnSealedCustomEquals.GetHashCode()' hides inherited member 'object.GetHashCode()'. To make the current member
99
override that implementation, add the override keyword. Otherwise add the new keyword."
10+
"CS1591: Missing XML comment for publicly visible type or member 'CoreDragDropManager'."
1011
"CS0219: The variable '__retval' is assigned but its value is never used."
1112
"CS0628: 'ToggleSwitch.OnToggled()': new protected member declared in sealed type"
1213
"CS0660: 'CustomEquals2' defines operator == or operator != but does not override Object.Equals(object o)"
1314
"CA2257: The 'ABI.Windows.Foundation.Collections.IMapChangedEventArgs<K>.Vftbl' member on the 'ABI.Windows.Foundation.Collections.IMapChangedEventArgs<K>'
1415
type should be marked 'static' as 'ABI.Windows.Foundation.Collections.IMapChangedEventArgs<K>' has the 'DynamicInterfaceImplementationAttribute' applied"
1516
-->
16-
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS0108;CS0109;CS0114;CS0219;CS0628;CS0660;CA2257</WarningsNotAsErrors>
17+
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS0108;CS0109;CS0114;CS1591;CS0219;CS0628;CS0660;CA2257</WarningsNotAsErrors>
1718

1819
<!-- Generated projections surface evaluation-only ('[Experimental]') Windows Runtime APIs, so 'CS8305' is expected -->
1920
<NoWarn>$(NoWarn);CS8305</NoWarn>

0 commit comments

Comments
 (0)