Add assertion-error to allowed dependencies#1206
Merged
jakebailey merged 1 commit intoOct 4, 2025
Merged
Conversation
Member
|
What version of chai does this? I checked latest and it doesn't list it as a dep, but maybe I missed something. |
Contributor
Author
This affects at least the v5 branch. The And I think that the re-export happens here: https://github.com/chaijs/chai/blob/445243d5e769c6b155e2a35e25a5f747afd2da88/lib/chai.js#L8-L19 In any case, I do seem to be able to access the // package.json
{
"private": true,
"type": "module",
"name": "example",
"version": "0.0.1",
"dependencies": {
"chai": "^5"
}
}// index.js
import { AssertionError } from "chai";
console.log(AssertionError);$ node index.js
[class AssertionError extends Error] |
jakebailey
approved these changes
Oct 4, 2025
Member
|
Only in npm and older yarn, since they hoist. Anyway, thanks for explaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: DefinitelyTyped/DefinitelyTyped#73830
The
chaipackage uses and re-exports theAssertionErrorclass from this package.