Narrow DS440010 XML token matching to avoid substring false positives in identifiers#745
Draft
Narrow DS440010 XML token matching to avoid substring false positives in identifiers#745
Conversation
Agent-Logs-Url: https://github.com/microsoft/DevSkim/sessions/7520ac06-fa3a-479a-970b-eb806c2620e8 Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/DevSkim/sessions/7520ac06-fa3a-479a-970b-eb806c2620e8 Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positive in XML partial substring match
Narrow DS440010 XML token matching to avoid substring false positives in identifiers
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevSkim was reporting DS440010 when TLS-like token fragments appeared inside larger XML identifiers (for example,
DES_ANNO_SHAinsideSCPDES_ANNO_SHAPE_1). This change narrows matching so findings require standalone token boundaries in this pattern class.Rule update (DS440010)
rules/default/security/cryptography/hardcoded_tls.jsonwith explicit non-identifier boundaries.Built-in negative regression coverage
must-not-matchself-test for the reported XML case:<Cipher Name="SCPDES_ANNO_SHAPE_1" />Changelog
1.0.82entry documenting the DS440010 false-positive narrowing and new negative self-test.Example of the updated boundary guard: