Skip to content

Narrow DS440010 XML token matching to avoid substring false positives in identifiers #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −2
Draft

Narrow DS440010 XML token matching to avoid substring false positives in identifiers #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27be3d
Initial plan
Copilot May 6, 2026
658e827
Fix DS440010 XML substring false positive and add negative self-test
Copilot May 6, 2026
c65b8d7
Fix changelog rule ID reference for DS440010 update
Copilot May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.82] - 2026-05-06
### Fix
- Narrowed OpenSSL hardcoded TLS detection rule DS440010 to require standalone token matching, avoiding false positives when `DES` only appears as a substring in larger XML identifiers.
- Added a negative built-in self-test case for XML identifier `SCPDES_ANNO_SHAPE_1` to prevent regressions.

## [1.0.81] - 2026-04-16
### Pipeline
- Updates to fix release pipeline for VSCode extension.
Expand Down Expand Up @@ -440,4 +445,3 @@ New: `devskim analyze -I path/to/src -O path/to/out.sarif`

### Fixes
- Rule improvements and DevSkim engine performance and reliablity improvements.

5 changes: 4 additions & 1 deletion rules/default/security/cryptography/hardcoded_tls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@
"severity": "important",
"_comment": "Applies to all languages since many just wrap OpenSSL constructs.",
"rule_info": "DS440000.md",
"must-not-match": [
"<Cipher Name=\"SCPDES_ANNO_SHAPE_1\" />"
],
"patterns": [
{
"pattern": "SSLv2?3_method|D?TLSv1_([123]_)?(client_|server_)?method",
Expand Down Expand Up @@ -127,7 +130,7 @@
"_comment": "OpenSSL extension / options"
},
{
"pattern": "(AES|DH|DHE|ADH|CAMELLIA|EDH|EXP|DES|IDEA|RC4|NULL|GOST|EXP|ECDH|ECDHE|AECDH|PSK|SSL|RSA|TLS)_?([A-Z0-9]+_)+((SHA[0-9]*)|(MD5)|(GOST)[[A-Z0-9\\-]*)",
"pattern": "(?<![A-Z0-9_])(AES|DH|DHE|ADH|CAMELLIA|EDH|EXP|DES|IDEA|RC4|NULL|GOST|EXP|ECDH|ECDHE|AECDH|PSK|SSL|RSA|TLS)_?([A-Z0-9]+_)+((SHA[0-9]*)|(MD5)|(GOST)[[A-Z0-9\\-]*)(?![A-Z0-9_])",
"type": "regex",
"scopes": [
"code"
Expand Down