Conversation
walbourn
added
github_actions
walbourn
commented
May 20, 2025
walbourn
requested review from
Andrew-Farrier,
Copilot and
scm-xbox
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes and simplifies build definitions by introducing matrix strategies in Azure DevOps pipelines and tightening trigger filters across both GitHub Actions and ADO pipelines.
- Add
paths-ignorerules to all GitHub workflow files, ensuring GitHub Actions ignores.azuredevops/**while ADO ignores.github/** - Refactor the DirectXMath-GitHub-Dev17 pipeline to use a
strategy.matrixfor all build configurations and introduce a newBUILD_EXTSjob - Update trigger/PR exclude patterns in Azure DevOps pipelines to use recursive globs (e.g.,
.github/**instead of.github/*)
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/*.yml | Added common paths-ignore blocks and updated AzureDevOps ignore |
| .azuredevops/pipelines/DirectXMath-GitHub-Dev17.yml | Introduced strategy.matrix, collapsed repetitive VSBuild steps, added BUILD_EXTS job |
| .azuredevops/pipelines/DirectXMath-GitHub-MinGW.yml | Switched trigger/PR exclude from .github/* to .github/** |
| .azuredevops/pipelines/DirectXMath-GitHub-CMake.yml | Switched trigger/PR exclude from .github/* to .github/** |
| msbuildArchitecture: x64 | ||
| - task: VSBuild@1 | ||
| displayName: Build solution math3_2022.sln x86rel nointrinsics | ||
| displayName: Build solution math3_2022.sln |
There was a problem hiding this comment.
[nitpick] Include $(BuildPlatform) and $(BuildConfiguration) in the displayName (e.g., Build solution math3_2022.sln $(BuildPlatform) $(BuildConfiguration)) so each matrix job is clearly distinguishable in pipeline logs.
Suggested change
| displayName: Build solution math3_2022.sln | |
| displayName: Build solution math3_2022.sln $(BuildPlatform) $(BuildConfiguration) |
scm-xbox
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the use of strategy to the existing ADO pipelines.
strategymatrixto simplify the pipelines for GitHub and GitHub-Dev17