Code review feedback for WaveFrontReader (#239)

walbourn · web-flow · commit bf77fd3b200f · 2025-07-10T11:10:03.000-07:00
diff --git a/Utilities/WaveFrontReader.h b/Utilities/WaveFrontReader.h
@@ -45,8 +45,8 @@
 #endif
 
 #include <algorithm>
-#include <cctype>
 #include <cstdint>
+#include <cwctype>
 #include <fstream>
 #include <locale>
 #include <string>
@@ -377,7 +377,7 @@ namespace DX
                         materials.emplace_back(mat);
                     }
                 }
-                else if (!std::isprint(*strCommand.c_str()))
+                else if (!std::iswprint(*strCommand.c_str()))
                 {
                     // non-printable characters outside of comments mean this is not a text file
                     return E_FAIL;
@@ -484,7 +484,7 @@ namespace DX
                         }
                     }
                 }
-                else if (!std::isprint(*strCommand.c_str()))
+                else if (!std::iswprint(*strCommand.c_str()))
                 {
                     // non-printable characters outside of comments mean this is not a text file
                     return E_FAIL;

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,8 @@`
`45`	`45`	`#endif`
`46`	`46`
`47`	`47`	`#include <algorithm>`
`48`		`-#include <cctype>`
`49`	`48`	`#include <cstdint>`
	`49`	`+#include <cwctype>`
`50`	`50`	`#include <fstream>`
`51`	`51`	`#include <locale>`
`52`	`52`	`#include <string>`
`@@ -377,7 +377,7 @@ namespace DX`
`377`	`377`	`materials.emplace_back(mat);`
`378`	`378`	`}`
`379`	`379`	`}`
`380`		`- else if (!std::isprint(*strCommand.c_str()))`
	`380`	`+ else if (!std::iswprint(*strCommand.c_str()))`
`381`	`381`	`{`
`382`	`382`	`// non-printable characters outside of comments mean this is not a text file`
`383`	`383`	`return E_FAIL;`
`@@ -484,7 +484,7 @@ namespace DX`
`484`	`484`	`}`
`485`	`485`	`}`
`486`	`486`	`}`
`487`		`- else if (!std::isprint(*strCommand.c_str()))`
	`487`	`+ else if (!std::iswprint(*strCommand.c_str()))`
`488`	`488`	`{`
`489`	`489`	`// non-printable characters outside of comments mean this is not a text file`
`490`	`490`	`return E_FAIL;`