Open
Conversation
Member
Author
walbourn
force-pushed
the
optfacesnverts
branch
from
1f4a0bd to
4454814
Compare
walbourn
requested review from
Andrew-Farrier,
jonmartinms,
nadaOuf and
scm-xbox
There was a problem hiding this comment.
Pull request overview
This PR updates the DirectXMesh mesh-optimization public APIs (OptimizeFaces*) to require an nVerts parameter so the implementations can validate index buffer contents, improving robustness at the cost of an intentional breaking change.
Changes:
- Added
nVertstoOptimizeFaces,OptimizeFacesEx,OptimizeFacesLRU, andOptimizeFacesLRUEx(16-bit and 32-bit overloads) and propagated it through implementations/callers. - Added index-range validation in the OptimizeFaces implementations and updated
meshconvertto passmnVerts. - Updated release notes / Copilot instructions and adjusted GitHub Actions path filters to ignore
.github/*.mdchanges.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the breaking API change and shows callsite update (plus minor formatting tweaks). |
| Meshconvert/Mesh.cpp | Updates internal tool callsites to pass mnVerts into the new API signatures. |
| DirectXMesh/scoped.h | Header comment block updated with additional fwlink URLs. |
| DirectXMesh/DirectXMeshOptimizeTVC.cpp | Threads nVerts through TVC implementation and adds index validation. |
| DirectXMesh/DirectXMeshOptimizeLRU.cpp | Threads nVerts through LRU implementation and adds index validation. |
| DirectXMesh/DirectXMesh.h | Updates public API signatures to include nVerts and tweaks enum default literals. |
| .github/workflows/wsl.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/vcpkg.yml | Expands paths-ignore to include .github/*.md/.nuget/*; whitespace normalization. |
| .github/workflows/uwp.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/test.yml | Expands paths-ignore to include .github/*.md. |
| .github/workflows/msvc.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/msbuild.yml | Expands paths-ignore to include .github/*.md. |
| .github/workflows/main.yml | Expands paths-ignore to include .github/*.md. |
| .github/workflows/codeql.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/clangcl.yml | Expands paths-ignore to include .github/*.md. |
| .github/workflows/bvt.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/arm64bvt.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/workflows/arm64.yml | Expands paths-ignore to include .github/*.md; whitespace normalization. |
| .github/copilot-instructions.md | Refreshes Copilot guidance text to match current project/tooling conventions. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OptimizeFaces*methods need to take annVertsparameter in order to validate the indices array content. This is a breaking change but improves the robustness of the code.