Skip to content

Commit 464f750

Browse files
authored
[SPIR-V] Remove unnecessary cases for SampledTexture that are breaking builds (#8375)
Part of #7979 It's breaking the build because the SampledTexture types aren't wrapped around `#ifdef ENABLE_SPIRV_CODEGEN`. In fact, these cases aren't needed and should be removed. `GetBasicKindType` maps `ArBasicKind` values to Clang QualType objects. SampledTexture wrappers are not introduced through that mapping table, so it shouldn't be added here.
1 parent 212d85b commit 464f750

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

tools/clang/lib/Sema/SemaHLSL.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5010,10 +5010,6 @@ class HLSLExternalSource : public ExternalSemaSource {
50105010

50115011
case AR_OBJECT_TEXTURE1D:
50125012
case AR_OBJECT_TEXTURE1D_ARRAY:
5013-
#ifdef ENABLE_SPIRV_CODEGEN
5014-
case AR_OBJECT_VK_SAMPLED_TEXTURE1D:
5015-
case AR_OBJECT_VK_SAMPLED_TEXTURE1D_ARRAY:
5016-
#endif
50175013
case AR_OBJECT_TEXTURE2D:
50185014
case AR_OBJECT_TEXTURE2D_ARRAY:
50195015
case AR_OBJECT_TEXTURE3D:
@@ -11745,10 +11741,6 @@ void hlsl::DiagnoseRegisterType(clang::Sema *self, clang::SourceLocation loc,
1174511741

1174611742
case AR_OBJECT_TEXTURE1D:
1174711743
case AR_OBJECT_TEXTURE1D_ARRAY:
11748-
#ifdef ENABLE_SPIRV_CODEGEN
11749-
case AR_OBJECT_VK_SAMPLED_TEXTURE1D:
11750-
case AR_OBJECT_VK_SAMPLED_TEXTURE1D_ARRAY:
11751-
#endif
1175211744
case AR_OBJECT_TEXTURE2D:
1175311745
case AR_OBJECT_TEXTURE2D_ARRAY:
1175411746
case AR_OBJECT_TEXTURE3D:

0 commit comments

Comments
 (0)