Address copilot comments

Author: luciechoi

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -5074,7 +5074,9 @@ class HLSLExternalSource : public ExternalSemaSource {
       ResClass = DXIL::ResourceClass::UAV;
       return true;
     case AR_OBJECT_TEXTURE2D_ARRAY:
+#ifdef ENABLE_SPIRV_CODEGEN
     case AR_OBJECT_VK_SAMPLED_TEXTURE2D_ARRAY:
+#endif
       ResKind = DXIL::ResourceKind::Texture2DArray;
       ResClass = DXIL::ResourceClass::SRV;
       return true;

tools/clang/test/CodeGenSPIRV/vk.sampledtexture.get-dimensions.hlsl

@@ -48,7 +48,7 @@ void main() {
   tex2dArray.GetDimensions(width, height, elements);
 
 // CHECK:        [[t2_load:%[0-9]+]] = OpLoad [[type_2d_sampled_image_array]] %tex2dArray
-// CHECK-NEXT:   [[image4:%[0-9]+]] = OpImage %type_2d_image_array [[t2_load]]
+// CHECK-NEXT:   [[image4:%[0-9]+]] = OpImage [[type_2d_image_array]] [[t2_load]]
 // CHECK-NEXT:       [[mip:%[0-9]+]] = OpLoad %uint %mipLevel
 // CHECK-NEXT:   [[query4:%[0-9]+]] = OpImageQuerySizeLod %v3uint [[image4]] [[mip]]
 // CHECK-NEXT: [[query4_0:%[0-9]+]] = OpCompositeExtract %uint [[query4]] 0

tools/clang/test/CodeGenSPIRV/vk.sampledtexture.load.hlsl

@@ -17,15 +17,15 @@ float4 main(int3 location3: A, int4 location4: B) : SV_Target {
 // CHECK-NEXT: [[coord_0:%[0-9]+]] = OpVectorShuffle %v2int [[loc]] [[loc]] 0 1
 // CHECK-NEXT:   [[lod_0:%[0-9]+]] = OpCompositeExtract %int [[loc]] 2
 // CHECK-NEXT:    [[tex:%[0-9]+]] = OpLoad [[type_2d_sampled_image]] %tex2d
-// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage %type_2d_image [[tex]]
+// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage [[type_2d_image]] [[tex]]
 // CHECK-NEXT:       {{%[0-9]+}} = OpImageFetch %v4float [[tex_img]] [[coord_0]] Lod [[lod_0]]
     float4 val1 = tex2d.Load(location3);
 
 // CHECK:        [[loc:%[0-9]+]] = OpLoad %v3int %location3
 // CHECK-NEXT: [[coord_0:%[0-9]+]] = OpVectorShuffle %v2int [[loc]] [[loc]] 0 1
 // CHECK-NEXT:   [[lod_0:%[0-9]+]] = OpCompositeExtract %int [[loc]] 2
 // CHECK-NEXT:    [[tex:%[0-9]+]] = OpLoad [[type_2d_sampled_image]] %tex2d
-// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage %type_2d_image [[tex]]
+// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage [[type_2d_image]] [[tex]]
 // CHECK-NEXT:       {{%[0-9]+}} = OpImageFetch %v4float [[tex_img]] [[coord_0]] Lod|ConstOffset [[lod_0]] [[v2ic]]
     float4 val2 = tex2d.Load(location3, int2(1, 2));
 
@@ -37,7 +37,7 @@ float4 main(int3 location3: A, int4 location4: B) : SV_Target {
 // CHECK-NEXT: [[coord_0:%[0-9]+]] = OpVectorShuffle %v2int [[loc]] [[loc]] 0 1
 // CHECK-NEXT:   [[lod_0:%[0-9]+]] = OpCompositeExtract %int [[loc]] 2
 // CHECK-NEXT:    [[tex:%[0-9]+]] = OpLoad [[type_2d_sampled_image]] %tex2d
-// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage %type_2d_image [[tex]]
+// CHECK-NEXT:    [[tex_img:%[0-9]+]] = OpImage [[type_2d_image]] [[tex]]
 // CHECK-NEXT:[[structResult:%[0-9]+]] = OpImageSparseFetch %SparseResidencyStruct [[tex_img]] [[coord_0]] Lod|ConstOffset [[lod_0]] [[v2ic]]
 // CHECK-NEXT:      [[status:%[0-9]+]] = OpCompositeExtract %uint [[structResult]] 0
 // CHECK-NEXT:                        OpStore %status [[status]]