Execution Tests: Long Vector WaveActiveSum#7878
Merged
Merged
Conversation
…r floating point ops for now.
damyanp
reviewed
Nov 6, 2025
damyanp
reviewed
Nov 6, 2025
Member
You should explicitly mark these tests as priority 2 to prevent them from running, since we'll be setting the default for all the tests in the class to pri 0. |
Contributor
Author
|
Ah, yes! Much cleaner.
________________________________
From: Damyan Pepper ***@***.***>
Sent: Wednesday, November 5, 2025 8:09 PM
To: microsoft/DirectXShaderCompiler ***@***.***>
Cc: Alex Sepkowski ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DirectXShaderCompiler] Execution Tests: Long Vector WaveActiveSum (PR #7878)
@damyanp commented on this pull request.
________________________________
In tools/clang/unittests/HLSLExec/LongVectors.cpp<#7878 (comment)>:
+
+ MaxWaveSize = waveOpts.WaveLaneCountMax;
+ }
+
+ DXASSERT_NOMSG(MaxWaveSize > 0);
+ DXASSERT((MaxWaveSize & (MaxWaveSize - 1)) == 0, "must be a power of 2");
+
+ dispatchWaveOpTest<T, OP>(D3DDevice, VerboseLogging, OverrideInputSize,
+ MaxWaveSize);
+ }
+
+ template <typename T, OpType OP> void runTest() {
+ WEX::TestExecution::SetVerifyOutput verifySettings(
+ WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures);
+
+ CheckDevice();
Yup, I understand that. Since we create the device in TEST_CLASS_SETUP I'm suggesting that we check for / recover from a removed device in TEST_METHOD_SETUP rather than having to explicitly sprinkle calls to CheckDevice around.
—
Reply to this email directly, view it on GitHub<#7878 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABK4EW3DO745FD2EYFJARIT33LCXVAVCNFSM6AAAAACLIAQ7Q6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMRVHA2TMMBQGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
damyanp
requested changes
Nov 6, 2025
Member
damyanp
left a comment
There was a problem hiding this comment.
Some uncontroversial names that just need to be fixed and a suggestion for a simpler type for a string.
Otherwise LGTM.
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
joaosaffran
reviewed
Nov 6, 2025
Collaborator
joaosaffran
left a comment
There was a problem hiding this comment.
Some merges need to be cleaned, other than that LGTM
damyanp
reviewed
Nov 7, 2025
Member
damyanp
left a comment
There was a problem hiding this comment.
Basically I expect this'll LGTM once the compilation errors are fixed :)
damyanp
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the basic framework for WaveActiveOp tests and the test cases for WaveActiveSum.
This partially addresses #7472
WARP requires an update for this test to pass so this test will not run in automation for now (no priority set in TAEF metadata).