Add error diagnostic for semantic with parameters (#6487)#7126
Closed
tcorringham wants to merge 2 commits into
Closed
Add error diagnostic for semantic with parameters (#6487)#7126tcorringham wants to merge 2 commits into
tcorringham wants to merge 2 commits into
Conversation
A non-null parenthesized list following a semantic was mis-parsed as a direct initializer. When the semantic actions for a direct initializer are performed the type of the initializer is dereferenced - however as a semantic doesn't have a type this resulted in a NULLPTR being dereferenced which caused a crash. As semantics don't accept parameters any parenthesized list following a semantic is an error. We now generate an error diagnostic if a l-paren follows a semantic.
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Fix formatting.
Collaborator
Author
|
This issue has been fixed by the alternative PR #7729, so I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-null parenthesized list following a semantic was mis-parsed as a direct initializer. When the semantic actions for a direct initializer are performed the type of the initializer is dereferenced - however as a semantic doesn't have a type this resulted in a NULLPTR being dereferenced which caused a crash.
As semantics don't accept parameters any parenthesized list following a semantic is an error. We now generate an error diagnostic if a l-paren follows a semantic.
Fixes #6487