lower spirv ray query type to opaque debug type#7139
Conversation
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Thanks for contributing. This is a big help. The change look go to me.
You can add a test to https://github.com/microsoft/DirectXShaderCompiler/tree/20950d662f4d24850d7edfe1e647f6749d5c13b3/tools/clang/test/CodeGenSPIRV.
You can see examples in that directory. You'll want to add your hlsl source file with a RUN line at the top, and at least one CHECK line to look for code you expect to see.
You can run the tests by running:
ninja check-clang-codegenspirv
|
I am not building with ninja right now, but have a visual studio solution. Right now I am trying to launch tests via:
but it fails at the disassembly stage due to an invalid bitcode signature. Note that the compilation process seems to succeed. Whatever I am trying to do in order to make tests work, I seem to be completely on the wrong track here. That blocks me right now. No idea where to continue the investigation. |
|
Sorry, I did not get back to you. Can run the tests by building the |
ChristianReinbold
force-pushed
the
spv_debug_ray_queries
branch
from
e5da07d to
84a0e38
Compare
I am sorry for keeping you waiting so long. I had a large shift of priorities in work and then I forgot about this MR. I added the reproducer from the issue as a test and checked that it fails without the proposed change. I do not remember what I tried with |
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Looks good. You just need to add more to the test.
Co-authored-by: Steven Perron <stevenperron@google.com>
|
/AzurePiplines run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 participants
Pull request for Issue #7033. It is still lacking a test though. If you can give me a quick pointer to a test directory where I can reformulate my reproducer as a test, I will add it as well.