Execution Tests: Fix bugs in LoadAndStoreOps#7856
Merged
alsepkow merged 9 commits intoNov 3, 2025
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
damyanp
approved these changes
Oct 29, 2025
…structured buffers
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
alsepkow
force-pushed
the
user/alsepkow/StructuredBufferFix
branch
from
2818e2a to
54d31d7
Compare
Contributor
Author
|
Rebased to pick up fixes for asuint tests |
damyanp
approved these changes
Oct 29, 2025
bogner
reviewed
Oct 31, 2025
| // StructuredBuffers are capped at 2048 bytes. | ||
| MaxInputSize = 2048 / sizeof(T); | ||
|
|
||
| if (InputVectorSizes.back() < MaxInputSize) |
Collaborator
There was a problem hiding this comment.
I guess this avoids duplicating a test of the maximum input size, but what happens if InputVectorSizes.back() > MaxInputSize? Is that really something we want to test?
Contributor
Author
There was a problem hiding this comment.
Won't ever hit now. But its a fair point to keep this framework robust to future test cases that might test some larger user defined type.
I'll update it.
bogner
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three issues in the LoadAndStoreOp tests:
Buffer sizing for odd-sized vectors: Previously, stride and resource width calculations could misalign, causing runtime errors.
Descriptor correctness for StructuredBuffers: Formats, flags, and the StructuredByteStride were not consistently set. WARP tolerated this but some IHVs reported issues as their drivers are stricter about this.
Some of the StructuredBuffer tests were hitting the runtime size limit of 2048 bytes for StructuredBuffers. I updated the logic around InputVectorSizes to account for this.
These changes ensure proper alignment, descriptor initialization, and resource sizing across all of the test cases.