Skip to content

Fix lit / taef integration#7870

Merged
damyanp merged 4 commits into
microsoft:mainfrom
damyanp:lit_taef
Nov 5, 2025
Merged

Fix lit / taef integration#7870
damyanp merged 4 commits into
microsoft:mainfrom
damyanp:lit_taef

Conversation

@damyanp
Copy link
Copy Markdown
Member

@damyanp damyanp commented Nov 4, 2025

  • TAEF writes everything to stdout, so don't worry about separate out/err streams
  • Use a single regex match for the Summary string
  • TAEF's exit code doesn't reliably indicate skipped tests, so look for these explicitly in the summary
  • Always return the output with the result - so that --show-all will work correctly and we can see the output from tests regardless of their final result.

* TAEF writes everything to stdout, so don't worry about separate out/err streams
* Use a single regex match for the Summary string
* TAEF's exit code doesn't reliably indicate skipped tests, so look for these explicitly in the summary
* Always return the output with the result - so that `--show-all` will work correctly and we can see the output from tests regardless of their final result.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2025

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Copy Markdown
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread utils/lit/lit/formats/taef.py
Comment thread utils/lit/lit/formats/taef.py
@damyanp damyanp enabled auto-merge (squash) November 5, 2025 00:32
@damyanp damyanp merged commit b0245e3 into microsoft:main Nov 5, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Nov 5, 2025
@damyanp damyanp deleted the lit_taef branch November 5, 2025 01:03
damyanp added a commit that referenced this pull request Feb 10, 2026
* TAEF writes everything to stdout, so don't worry about separate
out/err streams
* Use a single regex match for the Summary string
* TAEF's exit code doesn't reliably indicate skipped tests, so look for
these explicitly in the summary
* Always return the output with the result - so that `--show-all` will
work correctly and we can see the output from tests regardless of their
final result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants