From f14ddda7a28bc0a3646fe5ae1e0628517dcc8467 Mon Sep 17 00:00:00 2001 From: Damyan Pepper Date: Tue, 4 Nov 2025 16:18:15 -0800 Subject: [PATCH 1/2] Fix LongVectors tests running as part of standard test passes Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2. Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9! --- tools/clang/unittests/HLSLExec/LongVectors.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp index 95b23ed5b3..60054b5b1d 100644 --- a/tools/clang/unittests/HLSLExec/LongVectors.cpp +++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp @@ -1353,6 +1353,7 @@ class DxilConf_SM69_Vectorized { TEST_CLASS_PROPERTY( "Kits.Specification", "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement") + TEST_METHOD_PROPERTY(L"Priority", L"0") END_TEST_CLASS() TEST_CLASS_SETUP(classSetup) { @@ -1419,8 +1420,14 @@ class DxilConf_SM69_Vectorized { OverrideInputSize); } - // Only skip unsupported tests for RITP runs. - const bool SkipUnsupported = IsRITP; + bool FailIfRequirementsNotMet = false; +#ifdef _HLK_CONF + FailIsRequirementsNotMet = true; +#endif + WEX::TestExecution::RuntimeParameters::TryGetValue( + L"FailIfRequirementsNotMet", FailIfRequirementsNotMet); + + const bool SkipUnsupported = !FailIfRequirementsNotMet; createDevice(&D3DDevice, ExecTestUtils::D3D_SHADER_MODEL_6_9, SkipUnsupported); } From a8f1d7fee2023a95c430c0a34c2d8e6e59825027 Mon Sep 17 00:00:00 2001 From: Damyan Pepper Date: Tue, 4 Nov 2025 17:06:42 -0800 Subject: [PATCH 2/2] Update tools/clang/unittests/HLSLExec/LongVectors.cpp Co-authored-by: Alex Sepkowski --- tools/clang/unittests/HLSLExec/LongVectors.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp index 60054b5b1d..8e8dea55f4 100644 --- a/tools/clang/unittests/HLSLExec/LongVectors.cpp +++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp @@ -1422,7 +1422,7 @@ class DxilConf_SM69_Vectorized { bool FailIfRequirementsNotMet = false; #ifdef _HLK_CONF - FailIsRequirementsNotMet = true; + FailIfRequirementsNotMet = true; #endif WEX::TestExecution::RuntimeParameters::TryGetValue( L"FailIfRequirementsNotMet", FailIfRequirementsNotMet);