Skip to content

[NFC] Clean up HlslExecTestUtils#7875

Merged
damyanp merged 4 commits into
microsoft:mainfrom
damyanp:agility
Nov 12, 2025
Merged

[NFC] Clean up HlslExecTestUtils#7875
damyanp merged 4 commits into
microsoft:mainfrom
damyanp:agility

Conversation

@damyanp
Copy link
Copy Markdown
Member

@damyanp damyanp commented Nov 5, 2025

An attempt was made to factor out some common code from ExecutionTest.cpp to be shared between LongVectors.cpp and ExecutionTest.cpp. Somehow this either wasn't completed, or got lost when it was merged from the 6.9 staging branch.

This change finishes extracting this code, as well as making it clear what the HlslExecTestUtils interface is.

An attempt was made to factor out some common code from ExecutionTest.cpp to be shared between LongVectors.cpp and ExecutionTest.cpp. Somehow this either wasn't completed, or got lost when it was merged from the 6.9 staging branch.

This change finishes extracting this code, as well as making it clear what the HlslExecTestUtils interface is.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Comment thread tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp
Copy link
Copy Markdown
Contributor

@alsepkow alsepkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damyanp
Copy link
Copy Markdown
Member Author

damyanp commented Nov 11, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damyanp damyanp merged commit 53b058b into microsoft:main Nov 12, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants