[NFC] Fix unused variable warning#7877
Merged
Merged
Conversation
DataSize is only used in a DXASSERT, which is compile out in some configurations resulting in a unused variable warning. This change adds a [[maybe_unused]] attribute to suppress that warning.
damyanp
changed the title
alsepkow
reviewed
Nov 5, 2025
| // enough space. | ||
| const size_t NumElements = TestData.size(); | ||
| const size_t DataSize = sizeof(T) * NumElements; | ||
| [[maybe_unused]] const size_t DataSize = sizeof(T) * NumElements; |
Contributor
There was a problem hiding this comment.
Could also just replace the use of DataSize with 'sizeof(T) * NumElements instead.
Member
Author
There was a problem hiding this comment.
That cascades a bit because there's a comment talking about DataSize above that would also need to be updated. Having the separate named variable is nice and self documenting.
bob80905
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataSize is only used in a DXASSERT, which is compile out in some configurations resulting in a unused variable warning. This change adds a [[maybe_unused]] attribute to suppress that warning.