Skip to content

[SM6.10][Bugfix] Fix Size check for input interpreted vector in MultiplyAdd#8388

Merged
hekota merged 2 commits intomicrosoft:mainfrom
hekota:fix-size-check
Apr 20, 2026
Merged

[SM6.10][Bugfix] Fix Size check for input interpreted vector in MultiplyAdd#8388
hekota merged 2 commits intomicrosoft:mainfrom
hekota:fix-size-check

Conversation

@hekota
Copy link
Copy Markdown
Member

@hekota hekota commented Apr 18, 2026

Fixes vector size check for input interpreted vector.

Adds tests for MultiplyAdd with odd vector and matrix sizes, and with packed input vector.

Fixes #8385

…plyAdd

Fixes vector size check for input interpreted vector.

Adds tests for MultiplyAdd with odd sizes and with packed input vector.

Fixes microsoft#8385
Comment thread tools/clang/lib/Headers/hlsl/dx/linalg.h Outdated
Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right check is for a range, but this will unblock valid scenarios for now, so we should at least get this mitigation in.

Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hekota hekota enabled auto-merge (squash) April 20, 2026 22:16
@hekota hekota merged commit d831cb4 into microsoft:main Apr 20, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[SM6.10] linalg::MultiplyAdd template: wrong Size check condition for InterpretedVector

3 participants