Skip to content

[NFC] Replacing .Resource and .Sampler with attribute check #8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaosaffran merged 3 commits into from
Jun 1, 2026
+23 −4
Merged

[NFC] Replacing .Resource and .Sampler with attribute check #8487

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e5f01f
replace string with attibute
joaosaffran May 28, 2026
1879a59
format
joaosaffran May 28, 2026
eee40bf
test fox
joaosaffran May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tools/clang/lib/SPIRV/AstTypeProbe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,8 +1021,9 @@ bool isResourceDescriptorHeap(const Decl *D) {
}

bool isResourceDescriptorHeap(QualType T) {
const RecordType *RT = T->getAs<RecordType>();
return RT && RT->getDecl()->getName() == ".Resource";
const HLSLDynamicResourceAttr *Attr =
getAttr<HLSLDynamicResourceAttr>(T);
return Attr && !Attr->getIsSampler();
}

bool isSamplerDescriptorHeap(const Decl *D) {
Expand All @@ -1031,8 +1032,9 @@ bool isSamplerDescriptorHeap(const Decl *D) {
}

bool isSamplerDescriptorHeap(QualType T) {
const RecordType *RT = T->getAs<RecordType>();
return RT && RT->getDecl()->getName() == ".Sampler";
const HLSLDynamicResourceAttr *Attr =
getAttr<HLSLDynamicResourceAttr>(T);
return Attr && Attr->getIsSampler();
}

bool isAKindOfStructuredOrByteBuffer(QualType type) {
Expand Down
Loading