Skip to content

[MSVC] Fix a warning that is a default-error on modern MSVC #8488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bob80905 merged 2 commits into from
May 29, 2026
+2 −1
Merged

[MSVC] Fix a warning that is a default-error on modern MSVC #8488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
367d464
first attempt
bob80905 May 28, 2026
ef2c79c
update condition
bob80905 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/llvm/ADT/StringRef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,8 @@ namespace llvm {
// allowed), but (b) misclassifies the the construction as nothrow. Newer libc++
// releases reject user specializations of this trait outright, and also compute
// the trait correctly without help.
#if !defined(_LIBCPP_VERSION)
#if !defined(_LIBCPP_VERSION) && \
!(defined(_MSVC_STL_UPDATE) && _MSVC_STL_UPDATE >= 202604L)
namespace std {
template<>
struct is_nothrow_constructible <std::string, llvm::StringRef>
Expand Down
Loading