Skip to content

Commit 851f962

Browse files
walbournwalbourn
authored
Code review feedback for DLL declimport/export (#548)
1 parent 40732d0 commit 851f962

23 files changed

Lines changed: 196 additions & 0 deletions

‎.azuredevops/policies/approvercountpolicy.yml‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: approver_count
2+
description: Approver count policy for mscodehub/DirectXTK/DirectXTK repository
3+
resource: repository
4+
where:
5+
configuration:
6+
approverCountPolicySettings:
7+
isBlocking: true
8+
requireMinimumApproverCount: 1
9+
creatorVoteCounts: false
10+
allowDownvotes: false
11+
sourcePushOptions:
12+
resetOnSourcePush: false
13+
requireVoteOnLastIteration: true
14+
requireVoteOnEachIteration: false
15+
resetRejectionsOnSourcePush: false
16+
blockLastPusherVote: true
17+
branchNames:
18+
- refs/heads/release
19+
- refs/heads/main
20+
displayName: mscodehub/DirectXTK/DirectXTK Approver Count Policy

‎Audio/SoundCommon.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,17 @@
2727

2828
#ifndef DIRECTX_TOOLKIT_API
2929
#ifdef DIRECTX_TOOLKIT_EXPORT
30+
#ifdef __GNUC__
31+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
32+
#else
3033
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
34+
#endif
3135
#elif defined(DIRECTX_TOOLKIT_IMPORT)
36+
#ifdef __GNUC__
37+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
38+
#else
3239
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
40+
#endif
3341
#else
3442
#define DIRECTX_TOOLKIT_API
3543
#endif

‎Inc/Audio.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,17 @@
6969

7070
#ifndef DIRECTX_TOOLKIT_API
7171
#ifdef DIRECTX_TOOLKIT_EXPORT
72+
#ifdef __GNUC__
73+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
74+
#else
7275
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
76+
#endif
7377
#elif defined(DIRECTX_TOOLKIT_IMPORT)
78+
#ifdef __GNUC__
79+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
80+
#else
7481
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
82+
#endif
7583
#else
7684
#define DIRECTX_TOOLKIT_API
7785
#endif

‎Inc/BufferHelpers.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,17 @@
2323

2424
#ifndef DIRECTX_TOOLKIT_API
2525
#ifdef DIRECTX_TOOLKIT_EXPORT
26+
#ifdef __GNUC__
27+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
28+
#else
2629
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
30+
#endif
2731
#elif defined(DIRECTX_TOOLKIT_IMPORT)
32+
#ifdef __GNUC__
33+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
34+
#else
2835
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
36+
#endif
2937
#else
3038
#define DIRECTX_TOOLKIT_API
3139
#endif

‎Inc/CommonStates.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,17 @@
1919

2020
#ifndef DIRECTX_TOOLKIT_API
2121
#ifdef DIRECTX_TOOLKIT_EXPORT
22+
#ifdef __GNUC__
23+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
24+
#else
2225
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
26+
#endif
2327
#elif defined(DIRECTX_TOOLKIT_IMPORT)
28+
#ifdef __GNUC__
29+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
30+
#else
2431
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
32+
#endif
2533
#else
2634
#define DIRECTX_TOOLKIT_API
2735
#endif

‎Inc/DDSTextureLoader.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,17 @@
2727

2828
#ifndef DIRECTX_TOOLKIT_API
2929
#ifdef DIRECTX_TOOLKIT_EXPORT
30+
#ifdef __GNUC__
31+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
32+
#else
3033
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
34+
#endif
3135
#elif defined(DIRECTX_TOOLKIT_IMPORT)
36+
#ifdef __GNUC__
37+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
38+
#else
3239
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
40+
#endif
3341
#else
3442
#define DIRECTX_TOOLKIT_API
3543
#endif

‎Inc/DirectXHelpers.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,17 @@
3535

3636
#ifndef DIRECTX_TOOLKIT_API
3737
#ifdef DIRECTX_TOOLKIT_EXPORT
38+
#ifdef __GNUC__
39+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
40+
#else
3841
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
42+
#endif
3943
#elif defined(DIRECTX_TOOLKIT_IMPORT)
44+
#ifdef __GNUC__
45+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
46+
#else
4047
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
48+
#endif
4149
#else
4250
#define DIRECTX_TOOLKIT_API
4351
#endif

‎Inc/Effects.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,17 @@
2626

2727
#ifndef DIRECTX_TOOLKIT_API
2828
#ifdef DIRECTX_TOOLKIT_EXPORT
29+
#ifdef __GNUC__
30+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
31+
#else
2932
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
33+
#endif
3034
#elif defined(DIRECTX_TOOLKIT_IMPORT)
35+
#ifdef __GNUC__
36+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
37+
#else
3138
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
39+
#endif
3240
#else
3341
#define DIRECTX_TOOLKIT_API
3442
#endif

‎Inc/GamePad.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,17 @@
5252

5353
#ifndef DIRECTX_TOOLKIT_API
5454
#ifdef DIRECTX_TOOLKIT_EXPORT
55+
#ifdef __GNUC__
56+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
57+
#else
5558
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
59+
#endif
5660
#elif defined(DIRECTX_TOOLKIT_IMPORT)
61+
#ifdef __GNUC__
62+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
63+
#else
5764
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
65+
#endif
5866
#else
5967
#define DIRECTX_TOOLKIT_API
6068
#endif

‎Inc/GeometricPrimitive.h‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,17 @@
2121

2222
#ifndef DIRECTX_TOOLKIT_API
2323
#ifdef DIRECTX_TOOLKIT_EXPORT
24+
#ifdef __GNUC__
25+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllexport))
26+
#else
2427
#define DIRECTX_TOOLKIT_API __declspec(dllexport)
28+
#endif
2529
#elif defined(DIRECTX_TOOLKIT_IMPORT)
30+
#ifdef __GNUC__
31+
#define DIRECTX_TOOLKIT_API __attribute__ ((dllimport))
32+
#else
2633
#define DIRECTX_TOOLKIT_API __declspec(dllimport)
34+
#endif
2735
#else
2836
#define DIRECTX_TOOLKIT_API
2937
#endif

0 commit comments

Comments
 (0)