Suppress some spurious CodeQL warnings (#549)

walbourn · web-flow · commit f9b9fa0f50b3 · 2025-03-31T13:55:59.000-07:00
diff --git a/Audio/SoundCommon.cpp b/Audio/SoundCommon.cpp
@@ -592,7 +592,7 @@ void DirectX::CreateADPCM(
     adpcm->wNumCoef = MSADPCM_NUM_COEFFICIENTS;
 
     static ADPCMCOEFSET aCoef[7] = { { 256, 0}, {512, -256}, {0,0}, {192,64}, {240,0}, {460, -208}, {392,-232} };
-    memcpy(&adpcm->aCoef, aCoef, sizeof(aCoef));
+    memcpy(&adpcm->aCoef, aCoef, sizeof(aCoef)); // [CodeQL.SM01947]: Code scanner doesn't understand the 0-length MSVC array extension. MSADPCM_FORMAT_EXTRA_BYTES includes this memory.
 
     assert(IsValid(wfx));
 }
diff --git a/Audio/WaveBankReader.cpp b/Audio/WaveBankReader.cpp
@@ -250,7 +250,7 @@ namespace
             fmt->wNumCoef = MSADPCM_NUM_COEFFICIENTS;
 
             static ADPCMCOEFSET aCoef[7] = { { 256, 0}, {512, -256}, {0,0}, {192,64}, {240,0}, {460, -208}, {392,-232} };
-            memcpy(&fmt->aCoef, aCoef, sizeof(aCoef));
+            memcpy(&fmt->aCoef, aCoef, sizeof(aCoef)); // [CodeQL.SM01947]: Code scanner doesn't understand the 0-length MSVC array extension. MSADPCM_FORMAT_EXTRA_BYTES includes this memory.
         }
     };
 

Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,7 @@ void DirectX::CreateADPCM(`
`592`	`592`	`adpcm->wNumCoef = MSADPCM_NUM_COEFFICIENTS;`
`593`	`593`
`594`	`594`	`static ADPCMCOEFSET aCoef[7] = { { 256, 0}, {512, -256}, {0,0}, {192,64}, {240,0}, {460, -208}, {392,-232} };`
`595`		`- memcpy(&adpcm->aCoef, aCoef, sizeof(aCoef));`
	`595`	`+ memcpy(&adpcm->aCoef, aCoef, sizeof(aCoef)); // [CodeQL.SM01947]: Code scanner doesn't understand the 0-length MSVC array extension. MSADPCM_FORMAT_EXTRA_BYTES includes this memory.`
`596`	`596`
`597`	`597`	`assert(IsValid(wfx));`
`598`	`598`	`}`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ namespace`
`250`	`250`	`fmt->wNumCoef = MSADPCM_NUM_COEFFICIENTS;`
`251`	`251`
`252`	`252`	`static ADPCMCOEFSET aCoef[7] = { { 256, 0}, {512, -256}, {0,0}, {192,64}, {240,0}, {460, -208}, {392,-232} };`
`253`		`- memcpy(&fmt->aCoef, aCoef, sizeof(aCoef));`
	`253`	`+ memcpy(&fmt->aCoef, aCoef, sizeof(aCoef)); // [CodeQL.SM01947]: Code scanner doesn't understand the 0-length MSVC array extension. MSADPCM_FORMAT_EXTRA_BYTES includes this memory.`
`254`	`254`	`}`
`255`	`255`	`};`
`256`	`256`