Skip to content

Commit 1c9021b

Browse files
Rename QueryContainerLogV2CountsByComputer to GetComputerFromContainerLog
1 parent d0c379f commit 1c9021b

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/ginkgo-e2e/querylogs/querylogs_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ var _ = Describe("When querying ContainerLogV2 per node", func() {
5353
expectedNodes, err := utils.GetExpectedAmaLogsNodes(K8sClient)
5454
Expect(err).NotTo(HaveOccurred())
5555

56-
observed, err := utils.QueryContainerLogV2CountsByComputer(LogsClient, AKSResourceId, "5m")
56+
observed, err := utils.GetComputerFromContainerLog(LogsClient, AKSResourceId, "5m")
5757
Expect(err).NotTo(HaveOccurred())
5858

5959
Expect(utils.AssertContainerLogV2NodeCoverage(expectedNodes, observed)).NotTo(HaveOccurred())

test/ginkgo-e2e/utils/query_logs_api_utils.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,10 @@ func CompareResourcesInLogsAndKubeAPI(K8sClient *kubernetes.Clientset, logsClien
151151
return CompareResourcesHelper(logsClient, resourceID, query, resources)
152152
}
153153

154-
// QueryContainerLogV2CountsByComputer queries the Log Analytics workspace for
154+
// GetComputerFromContainerLog queries the Log Analytics workspace for
155155
// the number of ContainerLogV2 rows ingested per node (Computer) within the
156156
// given time window (e.g. "5m"). Returns a map keyed by lowercased Computer
157-
// name.
157+
// name with the row count as value.
158158
//
159159
// ContainerLogV2 and ContainerLog are mutually exclusive — a cluster writes
160160
// to one or the other based on its schema configuration. This helper only
@@ -163,7 +163,7 @@ func CompareResourcesInLogsAndKubeAPI(K8sClient *kubernetes.Clientset, logsClien
163163
// query that returns zero rows is treated as a real ingestion failure and
164164
// surfaced as an empty map; callers must NOT interpret that as a reason to
165165
// fall back, otherwise V2 ingestion failures would be silently masked.
166-
func QueryContainerLogV2CountsByComputer(logsClient *azquery.LogsClient, resourceID string, window string) (map[string]int64, error) {
166+
func GetComputerFromContainerLog(logsClient *azquery.LogsClient, resourceID string, window string) (map[string]int64, error) {
167167
counts, v2Err := queryCountsByComputer(logsClient, resourceID, "ContainerLogV2", window)
168168
if v2Err == nil {
169169
return counts, nil

0 commit comments

Comments
 (0)