Fix issue with "list index out of range" when max_iter=1#1419
Merged
thinkall merged 3 commits intoApr 9, 2025
Conversation
thinkall
reviewed
Apr 8, 2025
Collaborator
thinkall
left a comment
There was a problem hiding this comment.
Thank you for the PR, @Stickic-cyber . Please fix the format issue. Others LGTM, as we've discussed in #1417.
Contributor
Author
Thank you for the feedback! I've fixed the format issue as requested. The other parts remain unchanged |
Collaborator
|
@Stickic-cyber need to fix the test errors |
Contributor
Author
The test |
thinkall
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes a bug where
record_statewas not called whenmax_iter=1, ensuring consistent behavior across all iteration counts.The file 'test_max_iter_1.py' are needed to test that the AutoML process runs correctly by setting
max_iter=1, allowing model training and hyperparameter optimization.Related issue number
Closes #1416
Checks